From: Andrew Morton <akpm@osdl.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
drepper@redhat.com, dhowells@redhat.com
Subject: Re: [PATCH] [5/6] Handle TIF_RESTORE_SIGMASK for i386
Date: Fri, 13 Jan 2006 00:48:42 -0800 [thread overview]
Message-ID: <20060113004842.4c419174.akpm@osdl.org> (raw)
In-Reply-To: <1137140937.2675.4.camel@localhost.localdomain>
David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Fri, 2006-01-13 at 06:23 +0000, David Woodhouse wrote:
> > I suspect it might be the sigset size.
>
> I bet this is it, although I haven't yet confirmed the theory....
>
> Sorry, I should have tested this for myself on i386 before forwarding
> the patch. Stupid bloody legacy architecture :)
>
> --- linux-2.6.15.ppc/kernel/compat.c~ 2006-01-13 04:39:54.000000000 +0000
> +++ linux-2.6.15.ppc/kernel/compat.c 2006-01-13 08:23:24.000000000 +0000
> @@ -873,7 +873,7 @@ asmlinkage long compat_sys_stime(compat_
> #endif /* __ARCH_WANT_COMPAT_SYS_TIME */
>
> #ifdef __ARCH_WANT_COMPAT_SYS_RT_SIGSUSPEND
> -long compat_sys_rt_sigsuspend(compat_sigset_t __user *unewset, compat_size_t sigsetsize)
> +asmlinkage long compat_sys_rt_sigsuspend(compat_sigset_t __user *unewset, compat_size_t sigsetsize)
> {
> sigset_t newset;
> compat_sigset_t newset32;
> --- linux-2.6.15.ppc/kernel/signal.c~ 2006-01-13 04:39:54.000000000 +0000
> +++ linux-2.6.15.ppc/kernel/signal.c 2006-01-13 08:23:29.000000000 +0000
> @@ -2761,7 +2761,7 @@ sys_pause(void)
> #endif
>
> #ifdef __ARCH_WANT_SYS_RT_SIGSUSPEND
> -long sys_rt_sigsuspend(sigset_t __user *unewset, size_t sigsetsize)
> +asmlinkage long sys_rt_sigsuspend(sigset_t __user *unewset, size_t sigsetsize)
> {
> sigset_t newset;
I gues we want that, but x86 doesn't compile kernel/compat.c
next prev parent reply other threads:[~2006-01-13 8:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1136923488.3435.78.camel@localhost.localdomain>
2006-01-10 20:18 ` [PATCH] [1/6] Add pselect/ppoll system call implementation David Woodhouse
2006-01-13 11:40 ` Andrew Morton
2006-01-10 20:18 ` [PATCH] [2/6] TIF_RESTORE_SIGMASK support for arch/powerpc David Woodhouse
2006-01-10 20:18 ` [PATCH] [3/6] Generic sys_rt_sigsuspend() David Woodhouse
2006-01-10 20:19 ` [PATCH] [4/6] Handle TIF_RESTORE_SIGMASK for FRV David Woodhouse
2006-01-10 20:19 ` [PATCH] [5/6] Handle TIF_RESTORE_SIGMASK for i386 David Woodhouse
2006-01-13 3:59 ` Andrew Morton
2006-01-13 4:30 ` David Woodhouse
2006-01-13 4:54 ` Andrew Morton
2006-01-13 5:11 ` David Woodhouse
2006-01-13 6:10 ` Andrew Morton
2006-01-13 6:23 ` David Woodhouse
2006-01-13 8:28 ` David Woodhouse
2006-01-13 8:48 ` Andrew Morton [this message]
2006-01-13 8:51 ` Andrew Morton
2006-01-13 9:18 ` Andrew Morton
2006-01-10 20:23 ` [PATCH] [6/6] Add pselect/ppoll system calls on i386 David Woodhouse
2006-01-15 18:17 [PATCH] [5/6] Handle TIF_RESTORE_SIGMASK for i386 Oleg Nesterov
[not found] <1134732739.7104.54.camel@pmac.infradead.org>
2005-12-16 11:45 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060113004842.4c419174.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=drepper@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).