From: Jan Kara <jack@suse.cz>
To: Valdis.Kletnieks@vt.edu
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.15-mm3 - make useless quota error message informative
Date: Fri, 13 Jan 2006 16:02:24 +0100 [thread overview]
Message-ID: <20060113150224.GB9978@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <200601122044.k0CKihol003230@turing-police.cc.vt.edu>
> fs/quota_v2.c can, under some conditions, issue a kernel message that
> says, in totality, 'failed read'. This patch does the following:
>
> 1) Gives a hint who issued the error message, so people reading the logs
> don't have to go grepping the entire kernel tree (with 11 false positives).
>
> 2) Say what amount of data we expected, and actually got.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> ---
> --- linux-2.6.15-mm3/fs/quota_v2.c.quot-bug 2006-01-02 22:21:10.000000000 -0500
> +++ linux-2.6.15-mm3/fs/quota_v2.c 2006-01-12 15:26:43.000000000 -0500
> @@ -35,7 +35,8 @@ static int v2_check_quota_file(struct su
>
> size = sb->s_op->quota_read(sb, type, (char *)&dqhead, sizeof(struct v2_disk_dqheader), 0);
> if (size != sizeof(struct v2_disk_dqheader)) {
> - printk("failed read\n");
> + printk("quota_v2: failed read expected=%d got=%d\n",
> + sizeof(struct v2_disk_dqheader), size);
> return 0;
> }
> if (le32_to_cpu(dqhead.dqh_magic) != quota_magics[type] ||
>
The patch is fine. Thanks for fixing. I wonder how I managed to write such
error message ;).
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
prev parent reply other threads:[~2006-01-13 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 20:44 [PATCH] 2.6.15-mm3 - make useless quota error message informative Valdis.Kletnieks
2006-01-13 15:02 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060113150224.GB9978@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).