From: Jens Axboe <axboe@suse.de>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: ide <linux-ide@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
jgarzik <jgarzik@pobox.com>
Subject: Re: [PATCH 1/4] SATA ACPI build (applies to 2.6.16-git9)
Date: Mon, 16 Jan 2006 16:44:50 +0100 [thread overview]
Message-ID: <20060116154450.GK3945@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0601160736360.24990@shark.he.net>
On Mon, Jan 16 2006, Randy.Dunlap wrote:
> On Mon, 16 Jan 2006, Jens Axboe wrote:
>
> > On Fri, Jan 13 2006, Randy.Dunlap wrote:
> > > From: Randy Dunlap <randy_d_dunlap@linux.intel.com>
> > >
> > > Add ata_acpi in Makefile and Kconfig.
> > > Add ACPI obj_handle.
> > > Add ata_acpi.c to libata kernel-doc template file.
> >
> > Randy,
> >
> > Any chance you can add PATA support as well for this? Many of the
> > notebooks out there with SATA controllers really have PATA devices
> > behind a bridge, I think it's pretty much a pre-requisite for this to be
> > considered complete that this is supported as well. The code should be
> > the same, it just needs to lookup the right taskfiles. Right now on this
> > T43, it finds nothing.
>
> I'll add that to my list but I don't yet think that it's quite
> as simple as you make it sound...
It might not be, I'm totally acpi clueless :-)
But the code factoring should look something like this:
- Lookup taskfiles needed for resume (and suspend might need some,
too?). This step requires looking for sata and pata taskfiles listed,
so you'd need code for both.
- Submit and check status of said taskfiles. This step is independent of
the drive type.
So step 1 is the one that needs extending, how much work that is I
dunno since I have no clue on the actual lookup or the acpi data.
--
Jens Axboe
next prev parent reply other threads:[~2006-01-16 15:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 6:42 [PATCH 1/4] SATA ACPI build (applies to 2.6.16-git9) Randy.Dunlap
2006-01-14 6:44 ` [PATCH 2/4] libata debugging support Randy.Dunlap
2006-01-14 6:45 ` [PATCH 3/4] SATA ACPI objects support Randy.Dunlap
2006-01-14 6:45 ` [PATCH 4/4] additional libata parameters Randy.Dunlap
2006-01-18 0:35 ` [PATCH 2/4] libata debugging support Jeff Garzik
2006-01-14 7:28 ` [PATCH 1/4] SATA ACPI build (applies to 2.6.16-git9) Sam Ravnborg
2006-01-14 7:30 ` Randy.Dunlap
2006-01-16 11:56 ` Erik Mouw
2006-01-16 14:07 ` Erik Mouw
2006-01-16 21:04 ` Adrian Bunk
2006-01-17 9:01 ` Erik Mouw
2006-01-17 11:27 ` Adrian Bunk
2006-01-16 22:46 ` Jens Axboe
2006-01-16 22:48 ` Randy.Dunlap
2006-01-16 23:00 ` Alan Cox
2006-01-16 23:10 ` Jens Axboe
2006-01-18 12:24 ` Pavel Machek
2006-01-17 9:09 ` Erik Mouw
2006-01-16 15:40 ` Randy.Dunlap
2006-01-16 12:31 ` Jens Axboe
2006-01-16 15:37 ` Randy.Dunlap
2006-01-16 15:44 ` Jens Axboe [this message]
2006-01-16 15:51 ` Alan Cox
2006-01-16 15:52 ` Jens Axboe
2006-01-16 15:58 ` Randy.Dunlap
2006-01-16 16:02 ` Jens Axboe
2006-01-16 16:08 ` Randy.Dunlap
2006-01-16 22:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060116154450.GK3945@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).