From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932403AbWAQL1g (ORCPT ); Tue, 17 Jan 2006 06:27:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932401AbWAQL1g (ORCPT ); Tue, 17 Jan 2006 06:27:36 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:63762 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S932403AbWAQL1g (ORCPT ); Tue, 17 Jan 2006 06:27:36 -0500 Date: Tue, 17 Jan 2006 12:27:36 +0100 From: Adrian Bunk To: Erik Mouw Cc: "Randy.Dunlap" , ide , lkml , akpm , jgarzik Subject: Re: [PATCH 1/4] SATA ACPI build (applies to 2.6.16-git9) Message-ID: <20060117112736.GK29663@stusta.de> References: <20060113224252.38d8890f.rdunlap@xenotime.net> <20060116115607.GA18307@harddisk-recovery.nl> <20060116140713.GB18307@harddisk-recovery.com> <20060116210418.GG29663@stusta.de> <20060117090101.GA25963@harddisk-recovery.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060117090101.GA25963@harddisk-recovery.nl> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2006 at 10:01:01AM +0100, Erik Mouw wrote: > On Mon, Jan 16, 2006 at 10:04:18PM +0100, Adrian Bunk wrote: > > On Mon, Jan 16, 2006 at 03:07:13PM +0100, Erik Mouw wrote: > > > On Mon, Jan 16, 2006 at 12:56:07PM +0100, Erik Mouw wrote: > > > > Could you add some help text over here? At first glance I got the > > > > impression this was a host driver that works through ACPI calls, but by > > > > reading the rest of your patches it turns out it is a suspend/resume > > > > helper. > > > > > > Something like this should already be enough: > > > > > > This option enables support for SATA suspend/resume using ACPI. > > > > > > If you really need this enabled to be able to use suspend/resume at > > > all, you could add a line like: > > > > > > It's safe to say Y. If you say N, you might get serious disk > > > corruption when you suspend your machine. > > >... > > > > Why? > > > > This is not a user-visible option... > > Just curious, how do you see it's not user visible? There's neither a "prompt" line nor a string after the "bool". > Erik cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed