From: Andi Kleen <ak@suse.de>
To: discuss@x86-64.org
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
ACPI-ML <linux-acpi@vger.kernel.org>,
linux-ia64@vger.kernel.org,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
"Brown, Len" <len.brown@intel.com>
Subject: Re: [discuss] [PATCH/RFC] Unify mapping from PXM to node id.
Date: Tue, 17 Jan 2006 15:05:32 +0100 [thread overview]
Message-ID: <200601171505.32933.ak@suse.de> (raw)
In-Reply-To: <20060117205442.5B9A.Y-GOTO@jp.fujitsu.com>
On Tuesday 17 January 2006 13:36, Yasunori Goto wrote:
> Hello.
>
> This patch is to unify mapping from pxm to node id as a common code.
> In current code, i386, x86-64, and ia64 have its mapping by each own code.
> But PXM is defined by ACPI and node id is used generically. So,
> I think there is no reason to define it on each arch's code.
> This mapping should be written at drivers/acpi/numa.c.
>
> Please comment.
The array is unnecessary big - PXMs are only 8bit so it could be u8.
Looks ok to me on x86-64 in principle, except that the __devinits should
be probably __cpuinits. I haven't tested/compiled it though
-Andi
next prev parent reply other threads:[~2006-01-17 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 12:36 [PATCH/RFC] Unify mapping from PXM to node id Yasunori Goto
2006-01-17 14:05 ` Andi Kleen [this message]
2006-01-18 0:42 ` [discuss] " Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601171505.32933.ak@suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).