linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andi Kleen <ak@suse.de>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Jesper Juhl <jesper.juhl@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, Keith Owens <kaos@ocs.com.au>,
	Akinobu Mita <mita@miraclelinux.com>,
	Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH 3/4] compact print_symbol() output
Date: Tue, 17 Jan 2006 22:05:27 -0500	[thread overview]
Message-ID: <200601172208_MC3-1-B612-EE86@compuserve.com> (raw)

In-Reply-To: <200601171601.52995.ak@suse.de>

On Tue, 17 Jan 2006 at 16:01:52 +0100, Andi Kleen wrote:

> On Tuesday 17 January 2006 16:01, Hugh Dickins wrote:
> 
> > I've often found symbolsize useful.  Not when looking at an oops
> > from my own machine.  But when looking at an oops posted on LKML,
> > from someone who most likely has a different .config and different
> > compiler, different optimization and different inlining from mine.
> > symbolsize is a good clue as to how close their kernel is to the
> > one I've got built on my machine, how likely guesses I make based
> > on mine will apply to theirs, and whereabouts in the function that
> > it oopsed.
> 
> Yes that is why I want it too.

OK, how about this: remove the "0x" from the function size, i.e. print:

        kernel_symbol+0xd3/10e

instead of:

        kernel_symbol+0xd3/0x10e

This saves two characters per symbol and it should still be clear that
the second number is hexadecimal.

Does that break any tools?
-- 
Chuck

             reply	other threads:[~2006-01-18  3:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-18  3:05 Chuck Ebbert [this message]
2006-01-18  3:15 ` [PATCH 3/4] compact print_symbol() output Keith Owens
2006-01-18  3:25 ` Valdis.Kletnieks
  -- strict thread matches above, loose matches on Subject: below --
2006-01-18  6:08 Chuck Ebbert
2006-01-17 10:13 [PATCH 0/4] compact call trace Akinobu Mita
2006-01-17 10:15 ` [PATCH 3/4] compact print_symbol() output Akinobu Mita
2006-01-17 10:34   ` Keith Owens
2006-01-17 10:52     ` Jesper Juhl
2006-01-17 10:58       ` Akinobu Mita
2006-01-17 11:01         ` Keith Owens
2006-01-17 11:23     ` Akinobu Mita
2006-01-17 15:01       ` Hugh Dickins
2006-01-17 15:01         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601172208_MC3-1-B612-EE86@compuserve.com \
    --to=76306.1226@compuserve.com \
    --cc=ak@suse.de \
    --cc=arjan@infradead.org \
    --cc=hch@infradead.org \
    --cc=hugh@veritas.com \
    --cc=jesper.juhl@gmail.com \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mita@miraclelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).