From: Andrew Morton <akpm@osdl.org>
To: "Jiri Slaby" <xslaby@fi.muni.cz>
Cc: alan@lxorguk.ukuu.org.uk, bzolnier@gmail.com, calin@ajvar.org,
linux-kernel@vger.kernel.org
Subject: Re: PATCH: SBC EPX does not check/claim I/O ports it uses (2nd Edition)
Date: Wed, 18 Jan 2006 04:20:51 -0800 [thread overview]
Message-ID: <20060118042051.02fdc4ca.akpm@osdl.org> (raw)
In-Reply-To: <20060118121046.15C3122B38B@anxur.fi.muni.cz>
"Jiri Slaby" <xslaby@fi.muni.cz> wrote:
>
> > static void __exit watchdog_exit(void)
> But now, you forgot to add release_region in this (exit) function :)?
yup. That'll give a nice oops reading /proc/ioports after rmmod...
--- devel/drivers/char/watchdog/sbc_epx_c3.c~sbc-epx-does-not-check-claim-i-o-ports-it-uses-2nd-edition-fix 2006-01-18 04:19:58.000000000 -0800
+++ devel-akpm/drivers/char/watchdog/sbc_epx_c3.c 2006-01-18 04:19:58.000000000 -0800
@@ -213,6 +213,7 @@ static void __exit watchdog_exit(void)
{
misc_deregister(&epx_c3_miscdev);
unregister_reboot_notifier(&epx_c3_notifier);
+ release_region(EPXC3_WATCHDOG_CTL_REG, 2);
}
module_init(watchdog_init);
_
prev parent reply other threads:[~2006-01-18 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 17:52 PATCH: SBC EPX does not check/claim I/O ports it uses Alan Cox
2006-01-17 18:03 ` Bartlomiej Zolnierkiewicz
2006-01-17 18:09 ` Alan Cox
2006-01-17 18:42 ` PATCH: SBC EPX does not check/claim I/O ports it uses (2nd Edition) Alan Cox
2006-01-18 12:10 ` Jiri Slaby
2006-01-18 12:20 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118042051.02fdc4ca.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=calin@ajvar.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xslaby@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).