linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: Chuck Ebbert <76306.1226@compuserve.com>,
	linux-kernel@vger.kernel.org, torvalds@osdl.org,
	mita@miraclelinux.com, Keith Owens <kaos@ocs.com.au>
Subject: Re: [patch 2.6.15-current] i386: multi-column stack backtraces
Date: Wed, 18 Jan 2006 23:47:32 +0100	[thread overview]
Message-ID: <20060118224732.GA1812@elf.ucw.cz> (raw)
In-Reply-To: <20060116224234.5a7ca488.akpm@osdl.org>

Hi!

> > Print stack backtraces in multiple columns, saving screen space.
> > Number of columns is configurable and defaults to one so 
> > behavior is backwards-compatible.
> > 
> > Also removes the brackets around addresses when printing more
> > that one entry per line so they print as:
> >     <address>
> > instead of:
> >     [<address>]
> > This helps multiple entries fit better on one line.
> > 
> > Original idea by Dave Jones, taken from x86_64.
> > 
> 
> Presumably this is going to bust ksymoops.  Also the various other custom
> oops-parsers which people have written themselves.
> 
> > +config STACK_BACKTRACE_COLS
> 
> It's pretty sad to go and make something like this a config option.  But
> given that it is, believe it or not, an exported-to-userspace interface, I
> guess there's not much choice.

I don't think we should call printk()s "userspace interface". Yes,
someone may do dmesg | custom-grep-to-find-all-the-hardware, but
thats clearly stupid. I also believe that oops dump is so closely tied
to kernel that it is fair to change... plus this should better not be
configurable, or userspace will have hard time parsing it.
								Pavel
-- 
Thanks, Sharp!

  parent reply	other threads:[~2006-01-18 22:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17  6:23 [patch 2.6.15-current] i386: multi-column stack backtraces Chuck Ebbert
2006-01-17  6:39 ` Dave Jones
2006-01-17  6:42 ` Andrew Morton
2006-01-17  7:58   ` Dave Jones
2006-01-17  8:20     ` Andrew Morton
2006-01-17 10:26     ` Keith Owens
2006-01-17 17:12     ` Jan Engelhardt
2006-01-18  5:23       ` Keith Owens
2006-01-17 10:22   ` Keith Owens
2006-01-17 18:14     ` Sam Ravnborg
2006-01-18 22:47   ` Pavel Machek [this message]
2006-01-18  3:05 Chuck Ebbert
2006-01-19  0:36 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060118224732.GA1812@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=76306.1226@compuserve.com \
    --cc=akpm@osdl.org \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mita@miraclelinux.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).