linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Andrew Morton <akpm@osdl.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.16-rc1-mm2
Date: Fri, 20 Jan 2006 10:19:17 -0500	[thread overview]
Message-ID: <200601201519.k0KFJHh9016919@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Fri, 20 Jan 2006 03:40:27 PST." <20060120034027.665eb101.akpm@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

On Fri, 20 Jan 2006 03:40:27 PST, Andrew Morton said:
> Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> > Hmm. This still leaves kstrdup() broken which is why I would prefer
> > the following patch to be applied:
> 
> kstrdup() doesn't get used much.
> 
> > http://marc.theaimsgroup.com/?l=linux-kernel&m=113767657400334&w=2
> 
> That adds more complexity, IMO.  A bit ifdeffy too.  __do_kmalloc() should
> be __always_inline, methinks?

For what it's worth, I spent some time trying to get kstrdup() fixed as well,
but gave up because:

a) The leak I was chasing was using kzalloc() ;)

b) I got stuck in a .h dependency loop - the prototype for kzalloc is in
slab.h, and by that point in slab.h, we've seen a prototype for __kmalloc().
Unfortunately, kstrdup() comes out of string.h, and there's usages where
string.h has been #included but we've not seen __kmalloc().  Unfortunately,
just #include'ing what's needed didn't work, because of the way the code
uses #ifndef _LINUX_FOO_H_ - when I started looking at having to #undef stuff
to get a prototype of __kmalloc(), I gave up. ;)

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

  parent reply	other threads:[~2006-01-20 15:19 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-20 11:15 2.6.16-rc1-mm2 Andrew Morton
2006-01-20 11:33 ` 2.6.16-rc1-mm2 Pekka Enberg
2006-01-20 11:40   ` 2.6.16-rc1-mm2 Andrew Morton
2006-01-20 11:56     ` 2.6.16-rc1-mm2 Pekka J Enberg
2006-01-20 15:19     ` Valdis.Kletnieks [this message]
2006-01-20 13:58 ` [PATCH] zone_reclaim cpus_empty needs a real variable Andy Whitcroft
2006-01-20 16:28   ` Christoph Lameter
2006-01-20 21:34   ` Andrew Morton
2006-01-20 14:05 ` 2.6.16-rc1-mm2 Dave Jones
2006-01-20 16:23 ` Iptables error [Was: 2.6.16-rc1-mm2] Jiri Slaby
2006-01-20 16:36   ` Harald Welte
2006-01-20 16:41     ` Jiri Slaby
2006-01-20 16:43     ` Benoit Boissinot
2006-01-20 16:49       ` Linus Torvalds
2006-01-20 16:58         ` Benoit Boissinot
2006-01-20 17:38           ` Benoit Boissinot
2006-01-20 16:59         ` Jiri Slaby
2006-01-20 17:02           ` Jiri Slaby
2006-01-20 17:11         ` Carlos Silva
2006-01-20 19:32         ` Harald Welte
2006-01-20 19:46           ` Iptables error David S. Miller
2006-01-21 11:05             ` Harald Welte
2006-01-20 20:02         ` David S. Miller
2006-01-23  2:03         ` Iptables error [Was: 2.6.16-rc1-mm2] Herbert Xu
2006-01-23  2:23           ` Keith Owens
2006-01-23 20:53         ` Eric W. Biederman
2006-01-20 18:13   ` Valdis.Kletnieks
2006-01-20 19:52     ` Iptables error David S. Miller
2006-01-20 21:26 ` 2.6.16-rc1-mm2: arch/arm26/kernel/fiq.c still doesn't compile Adrian Bunk
2006-01-20 21:57   ` Alexey Dobriyan
2006-01-20 23:22 ` 2.6.16-rc1-mm2 Reuben Farrelly
2006-01-21 15:14   ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 16:39     ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 18:45       ` 2.6.16-rc1-mm2 Barry K. Nathan
2006-01-21 21:36         ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 23:57           ` 2.6.16-rc1-mm2 Barry K. Nathan
2006-01-23 12:39           ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-27 14:53             ` 2.6.16-rc1-mm2 Jeff Garzik
     [not found]               ` <200601280846.23279.edt@aei.ca>
2006-02-04 23:43                 ` 2.6.16-rc1-mm2 (mm5 too) panics Ed Tomlinson
2006-02-24  1:57                   ` 2.6.16-rc4-mm1 & " Ed Tomlinson
2006-01-24  3:51   ` 2.6.16-rc1-mm2 Neil Brown
2006-01-23 18:41 ` 2.6.16-rc1-mm2 Serge E. Hallyn
2006-01-23 18:47   ` 2.6.16-rc1-mm2 Christoph Lameter
2006-01-23 19:32     ` 2.6.16-rc1-mm2 Serge E. Hallyn
2006-01-23 19:39       ` 2.6.16-rc1-mm2 Christoph Lameter
2006-01-22  5:08 2.6.16-rc1-mm2 Chuck Ebbert
2006-01-22 14:18 2.6.16-rc1-mm2 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601201519.k0KFJHh9016919@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).