* __cpuinit functions wrongly marked __meminit
@ 2006-01-21 1:37 Ashok Raj
2006-01-21 2:00 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Ashok Raj @ 2006-01-21 1:37 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, ak, matthew.e.tolentino
Hi Andrew
This is required, __meminit has overzelously been modified and crept its way
into marking cpuup callbacks as __meminit.
I still have some trouble in getting cpu up to work on x86_64, even with these
changes and it might be some other changes that iam trying to hunt down.
Seems NUMA related. IA64 seems to work fine for now.
--
Cheers,
Ashok Raj
- Open Source Technology Center
__meminit has overzelously been modified and crept its way
into marking cpuup callbacks as __meminit.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
------------------------------------------------
mm/page_alloc.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6.16-rc1-mm2/mm/page_alloc.c
===================================================================
--- linux-2.6.16-rc1-mm2.orig/mm/page_alloc.c
+++ linux-2.6.16-rc1-mm2/mm/page_alloc.c
@@ -1876,7 +1876,7 @@ void zonetable_add(struct zone *zone, in
memmap_init_zone((size), (nid), (zone), (start_pfn))
#endif
-static int __meminit zone_batchsize(struct zone *zone)
+static int __cpuinit zone_batchsize(struct zone *zone)
{
int batch;
@@ -1970,7 +1970,7 @@ static struct per_cpu_pageset
* Dynamically allocate memory for the
* per cpu pageset array in struct zone.
*/
-static int __meminit process_zones(int cpu)
+static int __cpuinit process_zones(int cpu)
{
struct zone *zone, *dzone;
@@ -2011,7 +2011,7 @@ static inline void free_zone_pagesets(in
}
}
-static int __meminit pageset_cpuup_callback(struct notifier_block *nfb,
+static int __cpuinit pageset_cpuup_callback(struct notifier_block *nfb,
unsigned long action,
void *hcpu)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: __cpuinit functions wrongly marked __meminit
2006-01-21 1:37 __cpuinit functions wrongly marked __meminit Ashok Raj
@ 2006-01-21 2:00 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-01-21 2:00 UTC (permalink / raw)
To: Ashok Raj; +Cc: linux-kernel, ak, matthew.e.tolentino
Ashok Raj <ashok.raj@intel.com> wrote:
>
> __meminit has overzelously been modified and crept its way
> into marking cpuup callbacks as __meminit.
OK.
We do have tools which will auto-detect things like this.
reference_discarded.pl, reference_init.pl. I think they should work in
this case. One would need to use a number of .config combinations to get
full coverage of course.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: __cpuinit functions wrongly marked __meminit
@ 2006-01-21 16:45 Tolentino, Matthew E
0 siblings, 0 replies; 3+ messages in thread
From: Tolentino, Matthew E @ 2006-01-21 16:45 UTC (permalink / raw)
To: Raj, Ashok, linux-kernel; +Cc: akpm, ak
Ashok Raj <mailto:ashok.raj@intel.com> wrote:
> Hi Andrew
>
> This is required, __meminit has overzelously been modified and crept
> its way into marking cpuup callbacks as __meminit.
Indeed, thanks Ashok.
matt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-21 16:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-21 1:37 __cpuinit functions wrongly marked __meminit Ashok Raj
2006-01-21 2:00 ` Andrew Morton
2006-01-21 16:45 Tolentino, Matthew E
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).