From: "Vitaly V. Bursov" <vitalyb@telenet.dn.ua>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: linux 2.6.15.1 ppp_async panic on x86-64.
Date: Fri, 20 Jan 2006 23:25:17 +0200 [thread overview]
Message-ID: <20060120232517.4f0f551d.vitalyb@telenet.dn.ua> (raw)
In-Reply-To: <20060120043038.0dd9669b.akpm@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]
On Fri, 20 Jan 2006 04:30:38 -0800
Andrew Morton <akpm@osdl.org> wrote:
> "Vitaly V. Bursov" <vitalyb@telenet.dn.ua> wrote:
> >
> > PPP doesn't work for me on a x86-64 kernel.
> >
>
> The below was merged a couple of days ago, which should fix it. Can you
> please confirm that?
Yes, this patch resolves the problem.
Thanks.
> Begin forwarded message:
>
> Date: Tue, 17 Jan 2006 18:03:32 -0800
> From: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> To: git-commits-head@vger.kernel.org
> Subject: [NET]: Make second arg to skb_reserved() signed.
>
>
> tree 39750d44770efcdac150f041f71b7272c8da20f9
> parent f09484ff87f677056ce631aa3d8e486861501b51
> author David S. Miller <davem@sunset.davemloft.net> Tue, 17 Jan 2006 18:54:21 -0800
> committer David S. Miller <davem@sunset.davemloft.net> Tue, 17 Jan 2006 18:54:21 -0800
>
> [NET]: Make second arg to skb_reserved() signed.
>
> Some subsystems, such as PPP, can send negative values
> here. It just happened to work correctly on 32-bit with
> an unsigned value, but on 64-bit this explodes.
>
> Figured out by Paul Mackerras based upon several PPP crash
> reports.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> include/linux/skbuff.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index e5fd66c..ad7cc22 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -926,7 +926,7 @@ static inline int skb_tailroom(const str
> * Increase the headroom of an empty &sk_buff by reducing the tail
> * room. This is only allowed for an empty buffer.
> */
> -static inline void skb_reserve(struct sk_buff *skb, unsigned int len)
> +static inline void skb_reserve(struct sk_buff *skb, int len)
> {
> skb->data += len;
> skb->tail += len;
--
Vitaly DON'T PANIC
GPG Key ID: F95A23B9
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2006-01-20 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-15 19:48 linux 2.6.15.1 ppp_async panic on x86-64 Vitaly V. Bursov
2006-01-15 20:09 ` Diego Calleja
2006-01-15 20:41 ` Serge Belyshev
2006-01-16 3:03 ` Diego Calleja
2006-01-20 12:30 ` Andrew Morton
2006-01-20 21:25 ` Vitaly V. Bursov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060120232517.4f0f551d.vitalyb@telenet.dn.ua \
--to=vitalyb@telenet.dn.ua \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).