From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932143AbWAVIA0 (ORCPT ); Sun, 22 Jan 2006 03:00:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932158AbWAVIAZ (ORCPT ); Sun, 22 Jan 2006 03:00:25 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:34827 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S932143AbWAVIAZ (ORCPT ); Sun, 22 Jan 2006 03:00:25 -0500 Date: Sun, 22 Jan 2006 08:00:15 +0000 From: Russell King To: Andrew Morton Cc: Atsushi Nemoto , linux-kernel@vger.kernel.org, ralf@linux-mips.org Subject: Re: [PATCH] serial: serial_txx9 driver update Message-ID: <20060122080015.GA10398@flint.arm.linux.org.uk> Mail-Followup-To: Andrew Morton , Atsushi Nemoto , linux-kernel@vger.kernel.org, ralf@linux-mips.org References: <20060118.021901.71085469.anemo@mba.ocn.ne.jp> <20060121233649.51211403.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060121233649.51211403.akpm@osdl.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 21, 2006 at 11:36:49PM -0800, Andrew Morton wrote: > Atsushi Nemoto wrote: > > > > serial_txx9_verify_port(struct uart_port *port, struct serial_struct *ser) > > { > > - if (ser->irq < 0 || > > - ser->baud_base < 9600 || ser->type != PORT_TXX9) > > + unsigned long new_port = (unsigned long)ser->port + > > + ((unsigned long)ser->port_high << ((sizeof(long) - sizeof(int)) * 8)); > > Are you sure about this part? Shifting something left by sizeof(something) > seems very strange. It'll give different results on 64-bit machines for > the same hardware. Are you sure it wasn't supposed to be an addition? There is a definition for that constant - it's called HIGH_BITS_OFFSET. No need to try to buggily recreate it. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core