From: Andrew Morton <akpm@osdl.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: agk@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] device-mapper log bitset: fix endian
Date: Sun, 22 Jan 2006 23:51:30 -0800 [thread overview]
Message-ID: <20060122235130.0b8788df.akpm@osdl.org> (raw)
In-Reply-To: <1138002267.2977.19.camel@laptopd505.fenrus.org>
Arjan van de Ven <arjan@infradead.org> wrote:
>
> On Sun, 2006-01-22 at 21:37 -0800, Andrew Morton wrote:
> > Alasdair G Kergon <agk@redhat.com> wrote:
> > >
> > > - set_bit(bit, (unsigned long *) bs);
> > > + ext2_set_bit(bit, (unsigned long *) bs);
> >
> > We really should give those things a more appropriate name.
>
> or... kill them in favor of the real set_bit/__set_bit ?
No, they do different things on little-endian machines.
next prev parent reply other threads:[~2006-01-23 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 21:13 [PATCH 2/9] device-mapper log bitset: fix endian Alasdair G Kergon
2006-01-23 5:37 ` Andrew Morton
2006-01-23 7:44 ` Arjan van de Ven
2006-01-23 7:51 ` Andrew Morton [this message]
2006-01-23 21:09 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060122235130.0b8788df.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=agk@redhat.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).