From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: rmk+lkml@arm.linux.org.uk
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org
Subject: Re: [PATCH] serial: serial_txx9 driver update
Date: Mon, 23 Jan 2006 22:39:43 +0900 (JST) [thread overview]
Message-ID: <20060123.223943.104642974.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <20060123095700.GB4104@flint.arm.linux.org.uk>
>>>>> On Mon, 23 Jan 2006 09:57:00 +0000, Russell King <rmk+lkml@arm.linux.org.uk> said:
>> - if (disr & TXX9_SIDISR_UOER)
>> + if (disr & TXX9_SIDISR_UOER) {
>> up-> port.icount.overrun++;
>> + /*
>> + * The receiver read buffer still hold
>> + * a char which caused overrun.
>> + * Ignore next char by adding RFDN_MASK
>> + * to ignore_status_mask temporarily.
>> + */
>> + next_ignore_status_mask |=
>> + TXX9_SIDISR_RFDN_MASK;
>> + }
rmk> I'm not sure what you mean here.
rmk> If we successfully received the string ABCDEFGH, and the next character
rmk> to be received (I) causes an overrun condition, what happens in the
rmk> case that overruns are not ignored?
In this case, I will read ABCDEFG without errors, and then I with an overrun
rmk> Will you read ABCDEFG without any errors from the UART, and then H with
rmk> an overrun error? If so, you should pass to the TTY layer ABCDEFGH and
rmk> then a NUL character with TTY_OVERRUN set. Note that uart_insert_char()
rmk> does this for you.
Yes, in this case I will read ABCDEFG without error, and then H with
an overrun error. But the UART still hold "I" in its "read buffer".
The "read buffer" is exist outside the receiver FIFO. So if 'J' comes
in later, I will read "IJ". There is no way to clear the "read
buffer" except resetting the UART.
Resetting the whole UART is too intrusive, so I chose a way in the
patch (Ignore just next one char after an overrun error.)
---
Atsushi Nemoto
next prev parent reply other threads:[~2006-01-23 13:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 17:19 [PATCH] serial: serial_txx9 driver update Atsushi Nemoto
2006-01-22 7:36 ` Andrew Morton
2006-01-22 8:00 ` Russell King
2006-01-22 8:33 ` Andrew Morton
2006-01-22 23:02 ` Russell King
2006-01-23 6:05 ` Atsushi Nemoto
2006-01-23 9:57 ` Russell King
2006-01-23 13:39 ` Atsushi Nemoto [this message]
2006-01-23 13:42 ` Atsushi Nemoto
2006-01-23 19:49 ` Russell King
2006-01-24 2:24 ` Atsushi Nemoto
2006-12-21 17:01 Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060123.223943.104642974.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).