Re: [PATCH] cleanup of the drm sysfs code.

[Greg KH <greg@kroah.com>]

On Sun, Jan 22, 2006 at 11:03:16AM +1300, Dave Airlie wrote:
> > Kay pointed out today that the drm code creates a "dev" file in sysfs,
> > yet doesn't tell the driver core about it.  Normally this would be just
> > fine, as you are exporting the value in the proper style, but now there
> > are programs that are only watching the hotplug/uevent netlink messages
> > and not reading directly from sysfs to get this kind of information.
> > The patch below is a cleanup of the drm sysfs code, as much of the same
> > functionality that you want is already present in the driver core, so it
> > is not good to duplicate it.
> 
> Greg it looks fine to me, I'm LCA'ing at the moment, so if you can
> push it via your tree I'm fine with it, if you can let it sit in an
> -mm picked up tree for a bit I'd appreciate it, but we don't do much
> with sysfs anyways other than create the dev..

Ok, thanks.  I'll get it into the next few -mm releases, and as Linus is
also with you at linux.conf.au, I don't really worry about getting the
patch to him until he returns.

> I'm going to hopefully get around to the drm/fb merge layer in the
> next month so I'd prefer to start from a clean state..

Sounds good to me, I'll probably have the time to help out with this if
you want...

thanks,

greg k-h