* [PATCH] opl3sa2: fix adding second dma channel
@ 2006-01-25 0:42 Alexey Dobriyan
2006-01-25 14:38 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-01-25 0:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Zwane Mwaikambo
dma2 is a global array. sprintf below suggests there was a typo.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
sound/isa/opl3sa2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/isa/opl3sa2.c
+++ b/sound/isa/opl3sa2.c
@@ -721,7 +721,7 @@ static int __devinit snd_opl3sa2_probe(s
}
sprintf(card->longname, "%s at 0x%lx, irq %d, dma %d",
card->shortname, chip->port, xirq, xdma1);
- if (dma2 >= 0)
+ if (xdma2 >= 0)
sprintf(card->longname + strlen(card->longname), "&%d", xdma2);
return snd_card_register(card);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] opl3sa2: fix adding second dma channel
2006-01-25 0:42 [PATCH] opl3sa2: fix adding second dma channel Alexey Dobriyan
@ 2006-01-25 14:38 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2006-01-25 14:38 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Andrew Morton, linux-kernel, Zwane Mwaikambo
At Wed, 25 Jan 2006 03:42:49 +0300,
Alexey Dobriyan wrote:
>
> dma2 is a global array. sprintf below suggests there was a typo.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Thanks, I applied both patches to ALSA tree.
Takashi
> ---
>
> sound/isa/opl3sa2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/sound/isa/opl3sa2.c
> +++ b/sound/isa/opl3sa2.c
> @@ -721,7 +721,7 @@ static int __devinit snd_opl3sa2_probe(s
> }
> sprintf(card->longname, "%s at 0x%lx, irq %d, dma %d",
> card->shortname, chip->port, xirq, xdma1);
> - if (dma2 >= 0)
> + if (xdma2 >= 0)
> sprintf(card->longname + strlen(card->longname), "&%d", xdma2);
>
> return snd_card_register(card);
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-25 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-25 0:42 [PATCH] opl3sa2: fix adding second dma channel Alexey Dobriyan
2006-01-25 14:38 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).