From: Pavel Machek <pavel@ucw.cz>
To: Luca <kronos@kronoz.cjb.net>, mjg59@srcf.ucam.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: Suspend to RAM: help with whitelist wanted
Date: Sat, 28 Jan 2006 00:22:07 +0100 [thread overview]
Message-ID: <20060127232207.GB1617@elf.ucw.cz> (raw)
In-Reply-To: <20060127170406.GA6164@dreamland.darkstar.lan>
Hi!
> > On www.sf.net/projects/suspend , there's s2ram.c program for
> > suspending machines. It contains whitelist of known machines, along
> > with methods to get their video working (similar to
> > Doc*/power/video.txt). Unfortunately, video.txt does not allow me to
> > fill in whitelist automatically, so I need your help.
> >
> > I do not yet have solution for machines that need vbetool; fortunately
> > my machines do not need that :-), and it is pretty complex (includes
> > x86 emulator).
>
> What about adding something like:
>
> void s2ram_restore(void) {
> if (needed)
> fork_and_exec(vbetool);
> }
>
> machine_table could set a global flag or something. It would be
> possibile to us an array to carry the informations about what need to be
> done on restore, i.e. something like:
I can imagine fork_and_exec... Disadvantages are:
* if disk driver is toast, user does not see anything
* vbetool can be missing from the system, or wrong version, or
something like that.
Other solution is to just integrate vbetool into s2ram. Advantages
are:
* s2ram is nicely integrated.
Disadvantages are:
* code duplication.
If vbetool's primary purpose is to fix video after suspend/resume,
then perhaps right thing to do is to integrate it into s2ram and
maintain it there.
Matthew, what do you think?
Luca, would you cook quick&hacky fork-and-exec patch? I do not have
machine that needs vbetool...
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2006-01-27 23:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-26 21:36 Suspend to RAM: help with whitelist wanted Pavel Machek
2006-01-27 17:04 ` Luca
2006-01-27 23:05 ` Pavel Machek
2006-01-28 1:05 ` Olivier Galibert
2006-01-28 8:12 ` Pavel Machek
2006-01-27 23:22 ` Pavel Machek [this message]
2006-01-28 1:31 ` Matthew Garrett
2006-01-28 8:42 ` Pavel Machek
2006-01-29 7:12 ` Matthew Garrett
2006-02-04 21:11 ` Pavel Machek
2006-01-28 15:58 ` Luca
2006-01-28 16:04 ` Jan De Luyck
2006-01-28 17:11 ` Luca
2006-01-28 16:27 ` Pavel Machek
2006-01-28 16:36 ` Pavel Machek
2006-01-29 14:42 ` Luca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060127232207.GB1617@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=kronos@kronoz.cjb.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).