From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750719AbWA1Tdl (ORCPT ); Sat, 28 Jan 2006 14:33:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750715AbWA1Tdl (ORCPT ); Sat, 28 Jan 2006 14:33:41 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:58916 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S1750706AbWA1Tdk (ORCPT ); Sat, 28 Jan 2006 14:33:40 -0500 Date: Sat, 28 Jan 2006 20:27:14 +0100 From: Jens Axboe To: Nix Cc: Ariel , Jamie Heilman , Chase Venters , Arjan van de Ven , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: memory leak in scsi_cmd_cache 2.6.15 Message-ID: <20060128192714.GI9750@suse.de> References: <1137997104.2977.7.camel@laptopd505.fenrus.org> <200601230029.12674.chase.venters@clientec.com> <20060123072556.GC15490@fifty-fifty.audible.transient.net> <87ek2td4i9.fsf@amaterasu.srvr.nix> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ek2td4i9.fsf@amaterasu.srvr.nix> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27 2006, Nix wrote: > On 26 Jan 2006, Ariel noted: > > Is this good or bad? I'm guessing it means it's still leaking. So it's > > really starting to look like ata_piix is the problem. But we need someone > > who has the leak to remove that and see if it helps. I can't, since my > > drives are connected to it. > > FWIW, a bit of negative-confirmatory evidence: I have a sym53c875 > and non-SATA IDE drive on this 2.6.15.1, and there is no leak, > nor was there in 2.6.15: > > 11 11 100% 0.34K 1 11 4K scsi_cmd_cache It's not a bad data point, it just confirms that setting ->ordered_flush to 0 in the SATA drivers will fix the leak. So really, it's as expected. So far apparently nobody tried it, suggested it twice. -- Jens Axboe