From: Greg KH <greg@kroah.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/11] LED: Add LED Class
Date: Tue, 31 Jan 2006 12:59:28 -0800 [thread overview]
Message-ID: <20060131205928.GA24349@kroah.com> (raw)
In-Reply-To: <1138714888.6869.125.camel@localhost.localdomain>
On Tue, Jan 31, 2006 at 01:41:28PM +0000, Richard Purdie wrote:
> +/**
> + * led_device_register - register a new object of led_device class.
> + * @dev: The device to register.
> + * @led_dev: the led_device structure for this device.
> + */
> +int led_device_register(struct device *dev, struct led_device *led_dev)
Shouldn't struct led_device contain a struct device within it, like the
rest of the driver model?
thanks,
greg k-h
next prev parent reply other threads:[~2006-01-31 21:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 13:41 [PATCH 0/11] LED Class, Triggers and Drivers Richard Purdie
2006-01-31 13:41 ` [PATCH 2/11] LED: Add LED Class Richard Purdie
2006-01-31 14:55 ` Jan-Benedict Glaw
2006-01-31 20:59 ` Greg KH [this message]
2006-01-31 21:41 ` Richard Purdie
2006-02-01 1:41 ` Greg KH
2006-01-31 13:41 ` [PATCH 4/11] LED: Add LED Timer Trigger Richard Purdie
2006-01-31 15:01 ` Jan-Benedict Glaw
2006-01-31 17:36 ` Richard Purdie
2006-01-31 15:04 ` [PATCH 0/11] LED Class, Triggers and Drivers Jan-Benedict Glaw
2006-01-31 15:33 ` Pierre Ossman
2006-01-31 16:48 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060131205928.GA24349@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).