Re: [PATCH] [CM4000,CM4040] Add device class bits to enable udev device creation

From: Harald Welte <laforge@gnumonks.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Joachim Breitner <mail@joachim-breitner.de>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	akpm@osdl.org
Subject: Re: [PATCH] [CM4000,CM4040] Add device class bits to enable udev device creation
Date: Wed, 1 Feb 2006 10:03:24 +0100	[thread overview]
Message-ID: <20060201090324.GA31060@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <200601312259.32863.dtor_core@ameritech.net>

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On Tue, Jan 31, 2006 at 10:59:32PM -0500, Dmitry Torokhov wrote:
> On Tuesday 31 January 2006 05:10, Harald Welte wrote:
> > @@ -756,6 +762,10 @@ static struct pcmcia_driver reader_drive
> >  static int __init cm4040_init(void)
> >  {
> >         printk(KERN_INFO "%s\n", version);
> > +       cmx_class = class_create(THIS_MODULE, "cmx");
> > +       if (!cmx_class)
> > +               return -1;
> > +
> > 
> 
> 
> Hi,
> 
> What is "cmx" exactly? Can we have more descriptive name for a class,
> please?

'cmx' is the prefix of the device names, how the original vendor drivers
named their devices.  'cmm' in the cm4000 case is 'card man mobile'.
'cmx' is its successor, cm4040.

I'll rename the classes, thanks for your suggestion.

-- 
- Harald Welte <laforge@gnumonks.org>          	        http://gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]