From: Evgeniy Dushistov <dushistov@mail.ru>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Mark CONFIG_UFS_FS_WRITE as BROKEN
Date: Wed, 1 Feb 2006 18:40:20 +0300 [thread overview]
Message-ID: <20060201154020.GA593@rain.homenetwork> (raw)
In-Reply-To: <20060131234634.GA13773@mipter.zuzino.mipt.ru>
On Wed, Feb 01, 2006 at 02:46:34AM +0300, Alexey Dobriyan wrote:
> OpenBSD doesn't see "." correctly in directories created by Linux.
The problem is in dir.c:ufs_make_empty, which create "." and ".."
entires, in this function i_size isn't updated,
so result directory has zero size.
This patch should solve the problem, can you try it?
Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
---
--- linux-2.6.16-rc1-mm4/fs/ufs/dir.c.orig 2006-02-01 18:29:28.943878250 +0300
+++ linux-2.6.16-rc1-mm4/fs/ufs/dir.c 2006-02-01 18:12:24.043826000 +0300
@@ -539,6 +539,7 @@ int ufs_make_empty(struct inode * inode,
return err;
inode->i_blocks = sb->s_blocksize / UFS_SECTOR_SIZE;
+ inode->i_size = sb->s_blocksize;
de = (struct ufs_dir_entry *) dir_block->b_data;
de->d_ino = cpu_to_fs32(sb, inode->i_ino);
ufs_set_de_type(sb, de, inode->i_mode);
--
/Evgeniy
next prev parent reply other threads:[~2006-02-01 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 23:46 [PATCH] Mark CONFIG_UFS_FS_WRITE as BROKEN Alexey Dobriyan
2006-02-01 15:40 ` Evgeniy Dushistov [this message]
2006-02-01 20:04 ` Re [2]: " Evgeniy Dushistov
2006-02-02 23:40 ` Andrew Morton
2006-02-03 17:46 ` Alexey Dobriyan
2006-02-03 22:44 ` Alexey Dobriyan
2006-02-04 1:18 ` [PATCH] ufs: fill i_size at directory creation Alexey Dobriyan
2006-02-04 6:18 ` Evgeniy Dushistov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060201154020.GA593@rain.homenetwork \
--to=dushistov@mail.ru \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).