From: Andrey Panin <pazke@donpac.ru>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SIIG 8-port serial boards support
Date: Fri, 3 Feb 2006 12:13:08 +0300 [thread overview]
Message-ID: <20060203091308.GA19805@pazke> (raw)
In-Reply-To: <20060202201734.GA17329@flint.arm.linux.org.uk>
On 033, 02 02, 2006 at 08:17:35 +0000, Russell King wrote:
> On Thu, Feb 02, 2006 at 04:27:26PM +0300, Andrey Panin wrote:
> > Pong :) Please see below. Does it look better now ?
>
> Thanks, applied.
>
> > BTW I have a question for you. I'm trying to add support for Advantech serial
> > cards into 8250_pci.c. These cards are based on Oxford Semiconductor 16C950
> > UARTs and some of then can work in RS485 mode. They use DTR to automatically
> > control direction of the RS485 transiever buffer and so need to set bits
> > 3 and 4 in the ACR register. Unfortunately there is currently no way to set
> > different ACR value. Is it okay to use unused[] array in the struct uart_port
> > to pass ACR value from 8250_pci.c to 8250.c ?
>
> As I've said many a time, we need a generic way to set different hand-
> shaking modes. I've suggested using some spare bits in termios in the
> past, but nothing ever came of that - folk lose interest at that point.
IMHO there is no need to userspace visible changes to support RS485 on these cards,
because some of them are RS485 only and some have jumpers for individual ports.
There is nothing that userspace can configure. We only need to set two bits in ACR
according to card type and jumper settings and UART will drive RS485 transiever
transparently.
Actually any program which want to talk with RS485 network should implement some
form of line discipline itself to prevent network collisions and kernel cannot
help with it much.
> So as far as I'm concerned, until folk start wanting to seriously
> discuss how to portably support different flow control methods, there's
> no real support for them.
For RS232 cace I agree, but for RS485 this is not needed IMHO.
--
Andrey Panin | Linux and UNIX system administrator
pazke@donpac.ru | PGP key: wwwkeys.pgp.net
next prev parent reply other threads:[~2006-02-03 9:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 8:25 [PATCH] SIIG 8-port serial boards support Andrey Panin
2006-01-24 21:01 ` Russell King
2006-02-02 10:26 ` Russell King
2006-02-02 13:27 ` Andrey Panin
[not found] ` <20060202201734.GA17329@flint.arm.linux.org.uk>
2006-02-03 9:13 ` Andrey Panin [this message]
2006-02-03 9:24 ` Russell King
2006-02-17 11:39 ` Andrey Panin
2006-02-17 20:02 ` Russell King
2006-02-17 20:14 ` Russell King
2006-02-17 21:27 ` Paul Fulghum
2006-02-17 21:39 ` Russell King
2006-02-17 21:52 ` Paul Fulghum
2006-02-17 20:32 Kilau, Scott
2006-02-17 21:26 ` Russell King
2006-02-17 22:25 linux
2006-02-17 22:39 ` Russell King
2006-02-17 23:11 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060203091308.GA19805@pazke \
--to=pazke@donpac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).