From: Alexey Dobriyan <adobriyan@gmail.com>
To: Evgeniy Dushistov <dushistov@mail.ru>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Re [2]: [PATCH] Mark CONFIG_UFS_FS_WRITE as BROKEN
Date: Fri, 3 Feb 2006 20:46:13 +0300 [thread overview]
Message-ID: <20060203174613.GA7823@mipter.zuzino.mipt.ru> (raw)
In-Reply-To: <20060201200410.GA11747@rain.homenetwork>
Thanks, these two patches makes things better but not much better.
1.
inode->i_blocks = sb->s_blocksize / UFS_SECTOR_SIZE;
+ inode->i_size = sb->s_blocksize;
de = (struct ufs_dir_entry *) dir_block->b_data;
This creates directories which are 2048 bytes in size. Native ones are
512 bytes.
inode->i_size = 512;
makes mkdir and rm reliable for me both on linux and OpenBSD.
2. Second patch indeed makes hangs disaapear. However, data corruption
is still in place:
Try
for i in $(seq 1 10000); do echo $i; done >10000-linux.txt
cp 10000-linux.txt >/mnt/openbsd/10000-openbsd.txt
Now corruption structure is following:
00000000 39 0a 33 30 39 30 0a 33 30 39 31 0a 33 30 39 32 |9.3090.3091.3092|
[snip]
000007f0 33 34 39 36 0a 33 34 39 37 0a 33 34 39 38 0a 33 |3496.3497.3498.3|
00000800 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00004000 36 36 0a 36 33 36 37 0a 36 33 36 38 0a 36 33 36 |66.6367.6368.636|
[snip]
000047f0 0a 36 37 37 33 0a 36 37 37 34 0a 36 37 37 35 0a |.6773.6774.6775.|
00004800 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00008000 36 34 33 0a 39 36 34 34 0a 39 36 34 35 0a 39 36 |643.9644.9645.96|
[snip]
000086f0 39 38 0a 39 39 39 39 0a 31 30 30 30 30 0a 00 00 |98.9999.10000...|
00008700 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
0000bef0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |..............|
0000befe
There are all zeros in 0800-4000 and 4800-8000 range. 0000-3800 from
original file is dropped (that 9 it's from 3089).
next prev parent reply other threads:[~2006-02-03 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 23:46 [PATCH] Mark CONFIG_UFS_FS_WRITE as BROKEN Alexey Dobriyan
2006-02-01 15:40 ` Evgeniy Dushistov
2006-02-01 20:04 ` Re [2]: " Evgeniy Dushistov
2006-02-02 23:40 ` Andrew Morton
2006-02-03 17:46 ` Alexey Dobriyan [this message]
2006-02-03 22:44 ` Alexey Dobriyan
2006-02-04 1:18 ` [PATCH] ufs: fill i_size at directory creation Alexey Dobriyan
2006-02-04 6:18 ` Evgeniy Dushistov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060203174613.GA7823@mipter.zuzino.mipt.ru \
--to=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).