From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'David Gibson'" <david@gibson.dropbear.id.au>,
<linux-ia64@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: IA64 non-contiguous memory space bugs
Date: Wed, 22 Feb 2006 08:19:51 -0800 [thread overview]
Message-ID: <200602221619.k1MGJog18578@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060222001359.GA23574@localhost.localdomain>
David Gibson wrote on Tuesday, February 21, 2006 4:14 PM
> --- working-2.6.orig/include/linux/mm.h 2004-09-07 10:38:00.000000000 +1000
> +++ working-2.6/include/linux/mm.h 2004-09-24 15:02:18.172776168 +1000
> @@ -41,6 +41,13 @@
> #define MM_VM_SIZE(mm) TASK_SIZE
> #endif
>
> +#ifndef REGION_MAX
> +#define REGION_MAX(addr) TASK_SIZE
> +#endif
> +
> +#define GOOD_TASK_VM_RANGE(addr, len) \
> + ( ((addr)+(len) >= (addr)) || ((addr)+(len) <= TASK_SIZE) \
> + || ((addr)+(len) <= REGION_MAX(addr)) )
Looks like the logic is reversed, should be && instead of ||.
- Ken
next prev parent reply other threads:[~2006-02-22 16:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 0:13 IA64 non-contiguous memory space bugs David Gibson
2006-02-22 0:39 ` David S. Miller
2006-02-22 2:17 ` David Gibson
2006-02-22 1:31 ` Chen, Kenneth W
2006-02-22 1:51 ` Chen, Kenneth W
2006-02-22 2:25 ` 'David Gibson'
2006-02-22 2:45 ` Chen, Kenneth W
2006-02-22 16:35 ` Hugh Dickins
2006-02-22 23:49 ` 'David Gibson'
2006-02-23 20:13 ` Hugh Dickins
2006-02-24 0:11 ` 'David Gibson'
2006-02-24 1:14 ` Chen, Kenneth W
2006-02-24 2:46 ` 'David Gibson'
2006-02-22 2:15 ` 'David Gibson'
2006-02-22 2:53 ` Chen, Kenneth W
2006-02-22 3:55 ` David Mosberger-Tang
2006-02-22 4:02 ` David Gibson
2006-02-22 16:19 ` Chen, Kenneth W [this message]
2006-02-22 23:26 ` 'David Gibson'
2006-02-22 3:01 Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602221619.k1MGJog18578@unix-os.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=david@gibson.dropbear.id.au \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).