From: Greg KH <gregkh@suse.de>
To: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
Cc: Neil Brown <neilb@suse.de>, Alasdair Kergon <agk@redhat.com>,
Lars Marowsky-Bree <lmb@suse.de>,
linux-kernel@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 1/3] sysfs representation of stacked devices (common) (rev.2)
Date: Thu, 23 Feb 2006 19:40:07 -0800 [thread overview]
Message-ID: <20060224034007.GA2769@suse.de> (raw)
In-Reply-To: <43FE09E1.4080907@ce.jp.nec.com>
On Thu, Feb 23, 2006 at 02:15:45PM -0500, Jun'ichi Nomura wrote:
> Hello Greg,
>
> >>>>+/* This is a mere directory in sysfs. No methods are needed. */
> >>>>+static struct kobj_type bd_holder_ktype = {
> >>>>+ .release = NULL,
> >>>>+ .sysfs_ops = NULL,
> >>>>+ .default_attrs = NULL,
> >>>>+};
> >>>
> >>>That doesn't look right. You always need a release function.
>
> I updated the patch based your comments.
> Could you take a look at this version whether there's
> any problematic use of sysfs/kobjects?
>
> - I removed embedded child-kobjects from struct block_device
> and struct gendisk which I added in my previous patch.
> Kobject registration occurs when gendisk or hd_struct is
> registered. Release function of the kobject type is added.
> - Reference counting of kobjects is done in much symmetric
> manner than before.
> - Added bd_claim_by_disk/bd_release_from_disk inline functions
> to help proper reference counting.
Looks great, only one comment:
> --- linux-2.6.16-rc4/fs/partitions/check.c 2006-02-17 17:23:45.000000000 -0500
> +++ linux-2.6.16-rc4/fs/partitions/check.c 2006-02-22 23:18:06.000000000 -0500
> @@ -297,6 +297,56 @@ struct kobj_type ktype_part = {
> .sysfs_ops = &part_sysfs_ops,
> };
>
> +static void dir_release(struct kobject *kobj)
> +{
> + kfree(kobj);
> +}
> +
> +static struct kobj_type dir_ktype = {
> + .release = dir_release,
> + .sysfs_ops = NULL,
> + .default_attrs = NULL,
> +};
> +
> +static inline struct kobject *add_dir(struct kobject *parent, const char *name)
> +{
> + struct kobject *k;
> +
> + if (!parent)
> + return NULL;
> +
> + k = kmalloc(sizeof(*k), GFP_KERNEL);
> + if (!k)
> + return NULL;
> +
> + memset(k, 0, sizeof(*k));
> + k->parent = parent;
> + k->ktype = &dir_ktype;
> + kobject_set_name(k, name);
> + kobject_register(k);
> +
> + return k;
> +}
This code looks good enough that we should add it to the core kobject
code, don't you think? Also, you might use kzalloc instead of kmalloc
here.
thanks,
greg k-h
next prev parent reply other threads:[~2006-02-25 7:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 16:06 [PATCH 0/3] sysfs representation of stacked devices (dm/md) (rev.2) Jun'ichi Nomura
2006-02-22 16:13 ` [PATCH 1/3] sysfs representation of stacked devices (common) (rev.2) Jun'ichi Nomura
2006-02-22 18:48 ` Greg KH
2006-02-22 22:22 ` Jun'ichi Nomura
2006-02-22 22:28 ` Greg KH
2006-02-23 19:15 ` Jun'ichi Nomura
2006-02-24 3:40 ` Greg KH [this message]
2006-02-27 16:09 ` Jun'ichi Nomura
2006-02-22 16:13 ` [PATCH 2/3] sysfs representation of stacked devices (dm) (rev.2) Jun'ichi Nomura
2006-02-22 16:34 ` Alasdair G Kergon
2006-02-22 17:13 ` Jun'ichi Nomura
2006-02-22 18:13 ` Alasdair G Kergon
2006-02-22 19:32 ` Jun'ichi Nomura
2006-02-22 16:13 ` [PATCH 3/3] sysfs representation of stacked devices (md) (rev.2) Jun'ichi Nomura
2006-02-22 18:47 ` [PATCH 0/3] sysfs representation of stacked devices (dm/md) (rev.2) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060224034007.GA2769@suse.de \
--to=gregkh@suse.de \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmb@suse.de \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).