From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Zachary Amsden <zach@vmware.com>
Cc: davej@redhat.com, linux-kernel@vger.kernel.org, ak@suse.de,
dhecht@vmware.com, torvalds@osdl.org
Subject: Re: [PATCH] Fix topology.c location
Date: Sat, 25 Feb 2006 10:09:54 -0800 [thread overview]
Message-ID: <20060225100954.92fe9425.rdunlap@xenotime.net> (raw)
In-Reply-To: <440093C6.4000904@vmware.com>
On Sat, 25 Feb 2006 09:28:38 -0800 Zachary Amsden wrote:
> Dave Jones wrote:
>
> >This change breaks x86-64 compiles, as it uses the same file.
> >
> >
>
> Thanks for fixing that. Have we decided that file sharing of this sort
> is a really bad idea yet? I still see early_printk and pci-direct.h
> sharing remains. If this sharing really must go on, isn't there a less
> ad-hoc way to do it? Or at least a mention in the file that "before you
> modify, note this is shared by arch foo".
I guess a note would be OK, but there are notes already in Makefile*.
oh, or in some .c file if it does #include another.c
or #include ../../arch/other/blah
For i386 and x86_64, currently almost any file could be shared, except for
the cpu-specific ones.
One hurdle to get over seems to be what would Andi accept.
---
~Randy
prev parent reply other threads:[~2006-02-25 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200602242305.k1ON5Tmb026520@hera.kernel.org>
2006-02-25 8:55 ` [PATCH] Fix topology.c location Dave Jones
2006-02-25 17:28 ` Zachary Amsden
2006-02-25 18:09 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060225100954.92fe9425.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=ak@suse.de \
--cc=davej@redhat.com \
--cc=dhecht@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).