From: Wolfgang Hoffmann <woho@woho.de>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: pomac@vapor.com,
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>,
Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, Pavel Volkovitskiy <int@mtx.ru>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert sky2 to 0.13a
Date: Mon, 27 Feb 2006 17:38:38 +0100 [thread overview]
Message-ID: <200602271738.38675.woho@woho.de> (raw)
In-Reply-To: <20060227080042.0cf3f05d@localhost.localdomain>
On Monday 27 February 2006 17:00, Stephen Hemminger wrote:
> On Mon, 27 Feb 2006 00:03:45 +0100
>
> Wolfgang Hoffmann <woho@woho.de> wrote:
> > > Bisect done:
> > >
> > > 4d52b48b43d0d1d5959fa722ee0046e3542e5e1b is first bad commit
> > > [PATCH] sky2: support msi interrupt (revised)
> > >
> > > Reverting this commit in git head seems to work, at least the driver
> > > builds and loads. Is that sane?
> > >
> > Ok, no hangs yet.
> >
> > Looking at the reverted commit, I wonder if modprobing sky2 with
> > disable_msi=1 is equivalent to reverting the commit?
>
> Could you try the current code with the disable_msi option?
> modprobe sky2 disable_msi=1
>
> That will run existing code without MSI.
2.6.16-rc5 with disable_msi=1 works for me, no hangs seen so far. I rsynced 80
GB of data, thats about 5-10 times more than I typically need to reproduce a
hang, so it seems to be solid. For the record: 2.6.16-rc5 with disable_msi=0
does hang.
I have not seen the memory trashing others reported, with no version I tested
so far. Maybe my scenario is not likely to trigger this, so I can't tell.
Unless a fix for msi is at hand, may I suggest for 2.6.16 to revert the msi
commit or switch the default to disable_msi=1?
I've updated bugzilla #6084 accordingly.
next prev parent reply other threads:[~2006-02-27 16:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-26 0:54 [PATCH] Revert sky2 to 0.13a Carl-Daniel Hailfinger
2006-02-26 2:03 ` Stephen Hemminger
2006-02-26 2:42 ` Ian Kumlien
2006-02-26 8:57 ` Wolfgang Hoffmann
2006-02-26 15:00 ` Ian Kumlien
2006-02-26 15:47 ` Arjan van de Ven
2006-02-26 16:13 ` Ian Kumlien
2006-02-26 22:38 ` Carl-Daniel Hailfinger
2006-02-27 0:43 ` Ian Kumlien
2006-02-27 18:50 ` Carl-Daniel Hailfinger
2006-02-26 18:13 ` Wolfgang Hoffmann
2006-02-26 22:31 ` Wolfgang Hoffmann
2006-02-26 23:03 ` Wolfgang Hoffmann
2006-02-27 16:00 ` Stephen Hemminger
2006-02-27 16:38 ` Wolfgang Hoffmann [this message]
2006-02-27 17:18 ` Stephen Hemminger
2006-02-27 17:48 ` Wolfgang Hoffmann
2006-02-27 18:27 ` Ian Kumlien
2006-02-27 18:38 ` Jeff Garzik
2006-02-26 15:28 ` Ian Kumlien
2006-02-26 2:25 ` Ian Kumlien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602271738.38675.woho@woho.de \
--to=woho@woho.de \
--cc=c-d.hailfinger.devel.2006@gmx.net \
--cc=int@mtx.ru \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pomac@vapor.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).