From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbWCEHVZ (ORCPT ); Sun, 5 Mar 2006 02:21:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752148AbWCEHVY (ORCPT ); Sun, 5 Mar 2006 02:21:24 -0500 Received: from smtp.osdl.org ([65.172.181.4]:12982 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1752139AbWCEHVY (ORCPT ); Sun, 5 Mar 2006 02:21:24 -0500 Date: Sat, 4 Mar 2006 23:19:51 -0800 From: Andrew Morton To: Chris Leech Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 5/8] [I/OAT] Structure changes for TCP recv offload to I/OAT Message-Id: <20060304231951.0e83e23b.akpm@osdl.org> In-Reply-To: <20060303214229.11908.19898.stgit@gitlost.site> References: <20060303214036.11908.10499.stgit@gitlost.site> <20060303214229.11908.19898.stgit@gitlost.site> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Chris Leech wrote: > > +#ifdef CONFIG_NET_DMA > +#include > +#endif Please move the ifdefs into the header and include it unconditionally (entire patchset).