From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932172AbWDFOzg (ORCPT ); Thu, 6 Apr 2006 10:55:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932175AbWDFOzf (ORCPT ); Thu, 6 Apr 2006 10:55:35 -0400 Received: from atlrel6.hp.com ([156.153.255.205]:19648 "EHLO atlrel6.hp.com") by vger.kernel.org with ESMTP id S932172AbWDFOze (ORCPT ); Thu, 6 Apr 2006 10:55:34 -0400 From: Bjorn Helgaas To: Russell King Subject: Re: 2.6.17-rc1-mm1 Date: Thu, 6 Apr 2006 08:55:27 -0600 User-Agent: KMail/1.8.3 Cc: "Luck, Tony" , Zou Nan hai , Andrew Morton , LKML , linux-ia64@vger.kernel.org References: <20060404014504.564bf45a.akpm@osdl.org> <20060406102154.GB28056@flint.arm.linux.org.uk> <20060406103427.GC28056@flint.arm.linux.org.uk> In-Reply-To: <20060406103427.GC28056@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200604060855.27673.bjorn.helgaas@hp.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 06 April 2006 04:34, Russell King wrote: > On Thu, Apr 06, 2006 at 11:21:54AM +0100, Russell King wrote: > > On Wed, Apr 05, 2006 at 04:01:08PM -0600, Bjorn Helgaas wrote: > > > [PATCH] vgacon: make VGA_MAP_MEM take size, remove extra use > > > > Ah, seems to be what I just suggested... > > > > > @@ -1020,14 +1019,14 @@ > > > char *charmap; > > > > > > if (vga_video_type != VIDEO_TYPE_EGAM) { > > > - charmap = (char *) VGA_MAP_MEM(colourmap); > > > + charmap = (char *) VGA_MAP_MEM(colourmap, 0); > > > > Don't like this though - can't we pass a real size here rather than zero? > > There seems to be several clues as to the maximum size: I didn't like it either, but was too lazy to work out the actual size, so I just preserved the previous behavior. Andrew's put my first patch in -mm already, so I'll put this size issue and your unmap suggestion on my to-do list.