From: Andrew Morton <akpm@osdl.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: shemminger@osdl.org, jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, fpavlic@de.ibm.com,
davem@sunset.davemloft.net
Subject: Re: [patch] ipv4: initialize arp_tbl rw lock
Date: Sat, 8 Apr 2006 03:12:35 -0700 [thread overview]
Message-ID: <20060408031235.5d1989df.akpm@osdl.org> (raw)
In-Reply-To: <20060408100213.GA9412@osiris.boeblingen.de.ibm.com>
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> Ok, so the problem seems to be that inet_init gets called after qeth_init.
> Looking at the top level Makefile this seems to be true for all network
> drivers in drivers/net/ and drivers/s390/net/ since we have
>
> vmlinux-main := $(core-y) $(libs-y) $(drivers-y) $(net-y)
>
> The patch below works for me... I guess there must be a better way to make
> sure that any networking driver's initcall is made before inet_init?
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b401942..c5cea07 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -567,7 +567,7 @@ #
> # System.map is generated to document addresses of all kernel symbols
>
> vmlinux-init := $(head-y) $(init-y)
> -vmlinux-main := $(core-y) $(libs-y) $(drivers-y) $(net-y)
> +vmlinux-main := $(core-y) $(libs-y) $(net-y) $(drivers-y)
<wonders what this will break>
I have a bad feeling that one day we're going to come unstuck with this
practice. Is there anything which dictates that the linker has to lay
sections out in .o-file-order?
Perhaps net initcalls should be using something higher priority than
device_initcall().
next prev parent reply other threads:[~2006-04-08 10:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 8:15 [patch] ipv4: initialize arp_tbl rw lock Heiko Carstens
2006-04-07 14:46 ` Stephen Hemminger
2006-04-08 10:02 ` Heiko Carstens
2006-04-08 10:12 ` Andrew Morton [this message]
2006-04-19 10:45 ` Christian Borntraeger
2006-04-19 20:12 ` David S. Miller
2006-04-20 13:11 ` Heiko Carstens
2006-04-08 10:14 ` David S. Miller
2006-04-08 10:42 ` Heiko Carstens
2006-04-08 12:14 ` Sam Ravnborg
2006-04-15 7:27 ` Heiko Carstens
2006-04-15 7:34 ` David S. Miller
2006-04-15 23:00 ` Heiko Carstens
2006-04-24 10:18 ` Heiko Carstens
2006-04-24 10:22 ` [patch] ipv4: inet_init() -> fs_initcall Heiko Carstens
2006-04-07 20:14 ` [patch] ipv4: initialize arp_tbl rw lock David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060408031235.5d1989df.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@sunset.davemloft.net \
--cc=fpavlic@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).