From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbWEAPHp (ORCPT ); Mon, 1 May 2006 11:07:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932138AbWEAPHo (ORCPT ); Mon, 1 May 2006 11:07:44 -0400 Received: from ns2.suse.de ([195.135.220.15]:64222 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S932132AbWEAPHn (ORCPT ); Mon, 1 May 2006 11:07:43 -0400 Date: Mon, 1 May 2006 08:05:50 -0700 From: Greg KH To: Jan Engelhardt Cc: Arjan van de Ven , James Morris , Christoph Hellwig , Andrew Morton , Stephen Smalley , T?r?k Edwin , linux-security-module@vger.kernel.org, Linux Kernel Mailing List , Chris Wright , Linus Torvalds Subject: Re: [PATCH 4/4] MultiAdmin module Message-ID: <20060501150550.GA8328@kroah.com> References: <20060417195146.GA8875@kroah.com> <1145462454.3085.62.camel@laptopd505.fenrus.org> <20060419201154.GB20545@kroah.com> <20060421150529.GA15811@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 01, 2006 at 03:50:21PM +0200, Jan Engelhardt wrote: > > [PATCH 4/4] MultiAdmin module > > - Add the MultiAdmin to the mainline tree. > I hope the rest is self-explanatory. > > Please do not mention CodingStyle for multiadm.c. I already know it. :) > And I will get to it should it really be merged. No one will review it if it isn't in the proper CodingStyle. We have a coding style for a reason, it makes it a very simple thing for anyone to review the code as the patterns are all the same. It turns out that people's brains get trained to ignore the patterns and see the details instead. Lots of research backs this up. So switch to the common coding style, otherwise no one will look at your code (or if they do, odds are they will miss a lot...) thanks, greg k-h