From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@lst.de>,
pbadari@us.ibm.com, linux-kernel@vger.kernel.org, bcrl@kvack.org,
cel@citi.umich.edu
Subject: Re: [PATCH 1/3] Vectorize aio_read/aio_write methods
Date: Tue, 9 May 2006 21:20:51 +0200 [thread overview]
Message-ID: <20060509192051.GA19378@lst.de> (raw)
In-Reply-To: <20060509121305.0840e770.akpm@osdl.org>
On Tue, May 09, 2006 at 12:13:05PM -0700, Andrew Morton wrote:
> > there's another patch ontop which I didn't bother to redo until this is
> > accepted which kills a lot more code. After that filesystems only have
> > to implement one method each for all kinds of read/write calls. Which
> > allows to both make the mm/filemap.c far less complex and actually
> > understandable aswell as for any filesystem that uses more complex
> > read/write variants than direct filemap.c calls. In addition to these
> > simplification we also get a feature (async vectored I/O) for free.
>
> Fair enough, thanks. Simplifying filemap.c would be a win.
>
> I'll crunch on these three patches in the normal fashion. It'll be good if
> we can get the followup patch done within the next week or two so we can
> get it all tested at the same time. Although from your description it
> doesn't sound like it'll be completely trivial...
That patch is lots of tirival and boring work. If anyone wants to beat
me to it:
- in any filesystem that implements the generic_file_aio_{read,write}
directly remove these apply this patch to the file_operations
vectors:
- .read = generic_file_read,
- .write = generic_file_write,
+ .read = do_sync_read,
+ .write = do_sync_write,
Note that this does _not_ cause additional indirection for normal
sys_read/sys_write calls because they call .aio_read/.aio_write
directly. It's only needed because we have various places in the
tree that like to call .read/.write directly
- in the filesystems that implement more or less trivial wrappers
around generic_file_read/generic_file_write to the
aio_read/aio_write prototypes so they can set .read/.write as above
- after that generic_file_read/generic_file_write/generic_file_read/
generic_file_write_nolock should have no callers left and the code
for read/write in mm/filemap.c can be collapsed into very few functions.
What's left should be something like:
- generic_file_aio_read
(__generic_file_aio_read and generic_file_aio_read merged into one)
- __generic_file_aio_write
(basically the current __generic_file_aio_write_nolock)
- generic_file_aio_write_nolock
- generic_file_aio_write
(small wrappers around __generic_file_aio_write)
next prev parent reply other threads:[~2006-05-09 19:21 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-02 15:07 [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Badari Pulavarty
2006-05-02 15:08 ` [PATCH 1/3] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-02 15:20 ` Chuck Lever
2006-05-02 15:35 ` Badari Pulavarty
2006-05-02 15:09 ` [PATCH 2/3] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-02 15:11 ` [PATCH 3/3] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-09 18:03 ` [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Badari Pulavarty
2006-05-09 18:07 ` [PATCH 1/3] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-09 19:01 ` Andrew Morton
2006-05-09 19:03 ` Christoph Hellwig
2006-05-09 19:13 ` Andrew Morton
2006-05-09 19:20 ` Christoph Hellwig [this message]
2006-05-09 23:57 ` Badari Pulavarty
2006-05-10 8:00 ` Christoph Hellwig
2006-05-10 15:01 ` Badari Pulavarty
2006-05-10 16:01 ` Badari Pulavarty
2006-05-10 20:50 ` Badari Pulavarty
2006-05-09 20:07 ` Badari Pulavarty
2006-05-09 23:53 ` Badari Pulavarty
2006-05-09 18:07 ` [PATCH 2/3] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-09 18:08 ` [PATCH 3/3] Zach's core aio changes to support vectored AIO Badari Pulavarty
2006-05-09 18:55 ` christoph
2006-05-09 20:05 ` Badari Pulavarty
2006-05-09 18:14 ` [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Benjamin LaHaise
2006-05-11 15:38 ` [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO Badari Pulavarty
2006-05-11 15:38 ` [PATCH 1/4] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-11 18:39 ` Andrew Morton
2006-05-11 19:33 ` Mark Fasheh
2006-05-11 18:47 ` Andrew Morton
2006-05-11 19:07 ` Badari Pulavarty
2006-05-11 20:21 ` Andrew Morton
2006-05-11 20:45 ` Badari Pulavarty
[not found] ` <4463AB55.2010105@citi.umich.edu>
[not found] ` <4463B368.9050602@us.ibm.com>
[not found] ` <4463B7B0.4000102@citi.umich.edu>
2006-05-11 22:50 ` Badari Pulavarty
2006-05-12 7:38 ` Christoph Hellwig
2006-05-11 18:52 ` Andrew Morton
2006-05-11 19:12 ` Badari Pulavarty
2006-05-12 10:03 ` Andrew Morton
2006-05-12 10:08 ` Andrew Morton
2006-05-12 13:56 ` Badari Pulavarty
2006-05-11 15:40 ` [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-11 15:42 ` [PATCH 3/4] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-11 15:43 ` [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups Badari Pulavarty
2006-05-15 21:19 ` [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO Badari Pulavarty
2006-05-15 21:21 ` [PATCH 1/4] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-15 21:22 ` [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-22 1:00 ` Andrew Morton
2006-05-22 4:39 ` Badari Pulavarty
2006-05-22 5:34 ` Christoph Hellwig
2006-05-22 8:16 ` Ian Kent
2006-05-22 8:19 ` Ian Kent
2006-05-22 9:29 ` Andrew Morton
2006-05-22 9:35 ` Andrew Morton
2006-05-22 10:32 ` Christoph Hellwig
2006-05-22 10:44 ` Andrew Morton
2006-05-22 10:50 ` Ian Kent
2006-05-22 15:24 ` Badari Pulavarty
2006-05-22 15:00 ` Badari Pulavarty
2006-05-22 17:06 ` Andrew Morton
2006-05-22 17:24 ` Badari Pulavarty
2006-05-23 8:29 ` Ian Kent
2006-05-23 14:35 ` Ian Kent
2006-05-28 0:15 ` Badari Pulavarty
2006-05-29 7:06 ` Ian Kent
2006-05-15 21:22 ` [PATCH 3/4] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-15 21:23 ` [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups Badari Pulavarty
2006-05-15 22:28 ` Nathan Scott
2006-05-15 22:42 ` Andrew Morton
2006-05-15 22:56 ` Nathan Scott
2006-05-15 22:47 ` Badari Pulavarty
2006-05-16 10:50 ` christoph
-- strict thread matches above, loose matches on Subject: below --
2006-03-08 0:19 [RFC PATCH 0/3] VFS changes to collapse all the vectored and AIO support Badari Pulavarty
2006-03-08 0:22 ` [PATCH 1/3] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-03-08 12:44 ` christoph
2006-02-02 16:12 [PATCH 0/3] VFS changes to collapse all the vectored and AIO support Badari Pulavarty
2006-02-02 16:14 ` [PATCH 1/3] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-02-04 13:28 ` Christoph Hellwig
2006-02-04 22:10 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060509192051.GA19378@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=cel@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).