From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030297AbWEKP6r (ORCPT ); Thu, 11 May 2006 11:58:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030300AbWEKP6r (ORCPT ); Thu, 11 May 2006 11:58:47 -0400 Received: from wohnheim.fh-wedel.de ([213.39.233.138]:17133 "EHLO wohnheim.fh-wedel.de") by vger.kernel.org with ESMTP id S1030297AbWEKP6r (ORCPT ); Thu, 11 May 2006 11:58:47 -0400 Date: Thu, 11 May 2006 17:55:37 +0200 From: =?iso-8859-1?Q?J=F6rn?= Engel To: Rik Bobbaers Cc: linux-kernel@vger.kernel.org Subject: Re: fix compiler warning in ip_nat_standalone.c Message-ID: <20060511155537.GF1104@wohnheim.fh-wedel.de> References: <200605111729.48871.Rik.Bobbaers@cc.kuleuven.be> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200605111729.48871.Rik.Bobbaers@cc.kuleuven.be> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2006 17:29:48 +0200, Rik Bobbaers wrote: > > i just made small patch that fixes a compiler warning: Just in case Al didn't make it clear enough in the recent thread: You cannot fix a compiler warning! Either the code is wrong or it is right. A compiler warning can indicate that code is wrong, or it is a false positive. If the code is wrong, fix the _code_. If it isn't, ignore the warning or fix the _compiler_. That said, your patch looks as if it would actually fix the code. I'm not firm enough with NAT to confirm that, though. So if it fixes the code, please state exactly that. Jörn -- Anything that can go wrong, will. -- Finagle's Law