From: Andrew Morton <akpm@osdl.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mingo@elte.hu, markh@compro.net, linux-kernel@vger.kernel.org,
dwalker@mvista.com, tglx@linutronix.de
Subject: Re: 3c59x vortex_timer rt hack (was: rt20 patch question)
Date: Fri, 12 May 2006 07:16:45 -0700 [thread overview]
Message-ID: <20060512071645.6b59e0a2.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0605120904110.30264@gandalf.stny.rr.com>
Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
>
> On Fri, 12 May 2006, Ingo Molnar wrote:
>
> > --- linux-rt.q.orig/drivers/net/3c59x.c
> > +++ linux-rt.q/drivers/net/3c59x.c
> > @@ -1897,7 +1897,8 @@ vortex_timer(unsigned long data)
> >
> > if (vp->medialock)
> > goto leave_media_alone;
> > - disable_irq(dev->irq);
> > + /* hack! */
> > + disable_irq_nosync(dev->irq);
> > old_window = ioread16(ioaddr + EL3_CMD) >> 13;
> > EL3WINDOW(4);
> > media_status = ioread16(ioaddr + Wn4_Media);
>
> BTW, I originally thought about having Mark do this, but I'm nervious
> about the side effects that this might have. Basically, it's doing
> ioreads from the device while the interrupt could be doing iowrites.
>
> I don't know the device well enough to know if this is a problem.
> I've added Andrew Morton to the CC list, since his name is all over the
> code.
>
> Andrew,
>
> Do you know off hand what the side-effects to the vortex card might be
> if we use disable_irq_nosync instead of disable_irq?
>
ooh, ow, sorry, that's lost in the mists of time. I don't know why we're
doing disable_irq() in there.
Whatever it does, I think you could take vp->lock instead - that'll stop
the interrupt handler from doing anything if it does get entered while this
CPU is running vortex_timer().
next prev parent reply other threads:[~2006-05-12 14:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-09 12:23 rt20 patch question Mark Hounschell
2006-05-09 14:38 ` Daniel Walker
2006-05-09 14:58 ` Mark Hounschell
2006-05-09 15:53 ` Daniel Walker
2006-05-10 12:39 ` Steven Rostedt
2006-05-10 13:06 ` Mark Hounschell
2006-05-10 14:10 ` Steven Rostedt
2006-05-10 15:33 ` Mark Hounschell
2006-05-10 16:17 ` Steven Rostedt
2006-05-10 18:30 ` Mark Hounschell
2006-05-10 18:49 ` Steven Rostedt
2006-05-10 19:28 ` Mark Hounschell
2006-05-11 11:25 ` Mark Hounschell
2006-05-11 12:01 ` Steven Rostedt
2006-05-11 12:22 ` Steven Rostedt
2006-05-11 13:02 ` Mark Hounschell
2006-05-11 13:14 ` Steven Rostedt
2006-05-11 13:26 ` Mark Hounschell
2006-05-11 13:53 ` Steven Rostedt
2006-05-11 14:57 ` Mark Hounschell
2006-05-12 6:47 ` Steven Rostedt
2006-05-12 7:33 ` Sébastien Dugué
2006-05-12 8:18 ` Mark Hounschell
2006-05-12 9:08 ` Mark Hounschell
2006-05-12 9:20 ` Steven Rostedt
2006-05-10 20:33 ` Steven Rostedt
2006-05-12 8:16 ` Ingo Molnar
2006-05-12 8:45 ` Steven Rostedt
2006-05-12 9:16 ` Ingo Molnar
2006-05-12 9:21 ` Ingo Molnar
2006-05-12 12:38 ` Mark Hounschell
2006-05-12 13:18 ` Steven Rostedt
2006-05-12 13:38 ` Mark Hounschell
2006-05-12 13:43 ` Mark Hounschell
2006-05-12 14:05 ` Steven Rostedt
2006-05-12 14:36 ` Mark Hounschell
2006-05-12 14:51 ` Steven Rostedt
2006-05-12 13:16 ` 3c59x vortex_timer rt hack (was: rt20 patch question) Steven Rostedt
2006-05-12 13:36 ` Ingo Molnar
2006-05-12 13:46 ` Steven Rostedt
2006-05-12 14:16 ` Andrew Morton [this message]
2006-05-12 14:32 ` Steven Rostedt
2006-05-12 14:39 ` Steven Rostedt
2006-05-12 14:43 ` Ingo Molnar
2006-05-12 14:49 ` Andrew Morton
2006-05-12 15:04 ` Steven Rostedt
2006-05-12 16:53 ` 3c59x vortex_timer rt hack Mark Hounschell
2006-05-12 15:22 ` 3c59x vortex_timer rt hack (was: rt20 patch question) Steven Rostedt
2006-05-12 15:23 ` Andrew Morton
2006-05-12 15:36 ` Steven Rostedt
2006-05-12 16:03 ` Andrew Morton
2006-05-12 16:11 ` Steven Rostedt
2006-05-12 16:27 ` Andrew Morton
2006-05-12 16:38 ` Steven Rostedt
2006-05-10 18:45 ` rt20 patch question Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060512071645.6b59e0a2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).