From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbWFWWcI (ORCPT ); Fri, 23 Jun 2006 18:32:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752144AbWFWWcI (ORCPT ); Fri, 23 Jun 2006 18:32:08 -0400 Received: from amsfep17-int.chello.nl ([213.46.243.15]:727 "EHLO amsfep11-int.chello.nl") by vger.kernel.org with ESMTP id S1752140AbWFWWb6 (ORCPT ); Fri, 23 Jun 2006 18:31:58 -0400 From: Peter Zijlstra To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Hugh Dickins , Andrew Morton , David Howells , Peter Zijlstra , Christoph Lameter , Martin Bligh , Nick Piggin , Linus Torvalds Date: Sat, 24 Jun 2006 00:31:55 +0200 Message-Id: <20060623223155.11513.5770.sendpatchset@lappy> In-Reply-To: <20060623223103.11513.50991.sendpatchset@lappy> References: <20060623223103.11513.50991.sendpatchset@lappy> Subject: [PATCH 5/5] mm: small cleanup of install_page() Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra Smallish cleanup to install_page(), could save a memory read (haven't checked the asm output) and sure looks nicer. Signed-off-by: Peter Zijlstra --- --- mm/fremap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: 2.6-mm/mm/fremap.c =================================================================== --- 2.6-mm.orig/mm/fremap.c 2006-06-19 16:20:52.000000000 +0200 +++ 2.6-mm/mm/fremap.c 2006-06-19 16:20:57.000000000 +0200 @@ -79,9 +79,9 @@ int install_page(struct mm_struct *mm, s inc_mm_counter(mm, file_rss); flush_icache_page(vma, page); - set_pte_at(mm, addr, pte, mk_pte(page, prot)); + pte_val = mk_pte(page, prot); + set_pte_at(mm, addr, pte, pte_val); page_add_file_rmap(page); - pte_val = *pte; update_mmu_cache(vma, addr, pte_val); lazy_mmu_prot_update(pte_val); err = 0;