linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank van Maarseveen <frankvm@frankvm.com>
To: Andi Kleen <ak@suse.de>
Cc: Al Boldi <a1426z@gawab.com>,
	Arjan van de Ven <arjan@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Don't randomize stack unless current->personality permits it
Date: Thu, 13 Jul 2006 11:44:02 +0200	[thread overview]
Message-ID: <20060713094402.GB2448@janus> (raw)
In-Reply-To: <p73sll6n73t.fsf@verdi.suse.de>

On Wed, Jul 12, 2006 at 06:03:18PM +0200, Andi Kleen wrote:
> Al Boldi <a1426z@gawab.com> writes:
> 
> > Frank van Maarseveen wrote:
> > >
> > > Do not randomize stack location unless current->personality permits it.
[...]
> > 
> > It still blips on my system.
> > 
> > echo 0 > /proc/sys/kernel/randomize_va_space makes the blips go away.
> > 
> > ???
> 
> fs/binfmt_elf.c:randomize_stack_top would need the same check

Actually, randomize_stack_top() checks

	if (current->flags & PF_RANDOMIZE) {

and it's only called from load_elf_binary() right after this:

	if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
		current->flags |= PF_RANDOMIZE;

Further on create_elf_tables() is called and that one calls arch_align_stack()
so maybe it is more appropriate to test (current->flags & PF_RANDOMIZE) in
arch_align_stack() instead of recomputing it.

-- 
Frank

  parent reply	other threads:[~2006-07-13  9:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-11 19:57 [PATCH] x86: Don't randomize stack unless current->personality permits it Al Boldi
2006-07-12 16:03 ` Andi Kleen
2006-07-12 20:12   ` Al Boldi
2006-07-12 20:27     ` Arjan van de Ven
2006-07-12 21:13       ` Al Boldi
2006-07-13  9:44   ` Frank van Maarseveen [this message]
2006-07-13 20:51     ` Al Boldi
2006-07-13 20:54       ` Arjan van de Ven
2006-07-15 11:29         ` Al Boldi
2006-07-15 12:22           ` Arjan van de Ven
2006-07-15 14:09             ` Al Boldi
2006-07-15 16:15               ` Arjan van de Ven
2006-07-15 17:39               ` Al Boldi
2006-07-17 15:50               ` Paulo Marques
2006-07-18  5:21                 ` Al Boldi
  -- strict thread matches above, loose matches on Subject: below --
2006-07-25  0:21 Chuck Ebbert
2006-07-25  4:57 ` Al Boldi
2006-07-19 17:02 Chuck Ebbert
2006-07-20 17:23 ` Al Boldi
2006-07-24 15:57   ` Al Boldi
2006-07-16  3:58 Chuck Ebbert
2006-07-16 19:49 ` Al Boldi
2006-07-11 15:22 Frank van Maarseveen
2006-07-11 20:11 ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060713094402.GB2448@janus \
    --to=frankvm@frankvm.com \
    --cc=a1426z@gawab.com \
    --cc=ak@suse.de \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).