From: Andrew Morton <akpm@osdl.org>
To: Josh Triplett <josht@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: vxfs_readdir locking incorrect: add lock_kernel() or remove unlock_kernel()?
Date: Mon, 24 Jul 2006 17:20:40 -0700 [thread overview]
Message-ID: <20060724172040.c177f173.akpm@osdl.org> (raw)
In-Reply-To: <1153780937.31581.13.camel@josh-work.beaverton.ibm.com>
On Mon, 24 Jul 2006 15:42:17 -0700
Josh Triplett <josht@us.ibm.com> wrote:
> Commit 7b2fd697427e73c81d5fa659efd91bd07d303b0e in the historical GIT
> tree stopped calling the readdir member of a file_operations struct with
> the big kernel lock held, and fixed up all the readdir functions to do
> their own locking. However, that change added calls to unlock_kernel()
> in vxfs_readdir (fs/freevxfs/vxfs_lookup.c), but no call to
> lock_kernel().
That would appear to imply that nobody has used freevxfs in four years.
> Should vxfs_readdir call lock_kernel(), or should the
> calls to unlock_kernel() go away?
I don't see anything in there which needs the locking, apart from perhaps
f_pos updates. But it's probably best to add the lock_kernel() - this is a
bugfixing exercise, not a remove-BKL-from-freevxfs exercise.
next prev parent reply other threads:[~2006-07-25 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 22:42 vxfs_readdir locking incorrect: add lock_kernel() or remove unlock_kernel()? Josh Triplett
2006-07-25 0:20 ` Andrew Morton [this message]
2006-07-25 22:25 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724172040.c177f173.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=josht@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).