From: "Horst H. von Brand" <vonbrand@inf.utfsm.cl>
To: "Joshua Hudson" <joshudson@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: what is necessary for directory hard links
Date: Mon, 24 Jul 2006 13:55:19 -0400 [thread overview]
Message-ID: <200607241755.k6OHtJuo006253@laptop13.inf.utfsm.cl> (raw)
In-Reply-To: Message from "Joshua Hudson" <joshudson@gmail.com> of "Mon, 24 Jul 2006 09:21:04 MST." <bda6d13a0607240921x78049eefraae775e4c6c0ba5c@mail.gmail.com>
Joshua Hudson <joshudson@gmail.com> wrote:
> On 7/24/06, Valdis.Kletnieks@vt.edu <Valdis.Kletnieks@vt.edu> wrote:
> > On Mon, 24 Jul 2006 10:45:45 +0400, Nikita Danilov said:
> > > Joshua Hudson writes:
> > > > In my filesystem, any attempt to create a loop of hard links
> > > > is detected and cancelled.
> > >
> > > Can you elaborate a bit on this exciting mechanism? Obviously an ability
> > > to efficiently detect loops would be a break-through in a
> > > reference-counted garbage collection, somehow missed for last 40
> > It's actually pretty trivial to do if it's a toy filesystem and all the
> > relevant inodes are in-memory already. The hard-to-solve part is getting
> > around the (apparent) need to walk across essentially the entire tree
> > structure making sure that you aren't creating a loop. This can get
> > rather performance piggy - even /home on my laptop has some 400K
> > inodes on it, and a 'find /home -type d' takes 28 seconds. That's a *long*
> > time to lock and freeze a filesystem.
> Actually, I walk from the source inode down to try to find the
> target inode. If not found, this is not attempting to create a loop.
> Should be obvious that the average case is much less than the
> whole tree.
You have to consider the worst case... and /that/ one is very bad.
> > Where it gets *really* messy is that it isn't just mkdir that's the
> > problem - once you let there be more than one path from the fs root to
> > a given directory, it gets *really* hard to make sure that any given
> > 'mv' command isn't going to to screw things up (is 'mv a/b/c/d
> > ../../w/z/b' safe? How do you know, without examining a *lot* of stuff
> > under a/ and ../../w/?
> mv /a/b/c/d ../../w/z/b is implemented as this in the filesystem:
> ln /a/b/c/d ../../w/z/b && rm /a/b/c/d
>
> So what it's going to do is try to find z under /a/b/c/d.
What if the ln(1) creates a loop, that the rm(1) then breaks? I.e., move a
directory nearer to the root?
Also note that with your idea '..' becomes ambiguous, as w might have
/lots/ of parents here.
> Oh, and Nakita's right about the NFS server stuff. Actually, I think
> the current filesystem I use for this is totally incompatible with
> NFS (cannot call d_splice_alias on directory dnodes) so that
> doesn't concern me.
Anything that isn't even NFS-capable is almost useless, IMVHO. Unless you
come up with a successor to NFS in tandem, that is.
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
next prev parent reply other threads:[~2006-07-24 17:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6ARGK-19L-5@gated-at.bofh.it>
[not found] ` <6B8og-1iB-17@gated-at.bofh.it>
2006-07-22 16:59 ` what is necessary for directory hard links Bodo Eggert
2006-07-22 18:13 ` Joshua Hudson
2006-07-24 6:45 ` Nikita Danilov
2006-07-24 7:25 ` Valdis.Kletnieks
2006-07-24 16:21 ` Joshua Hudson
2006-07-24 17:55 ` Horst H. von Brand [this message]
2006-07-24 18:22 ` Valdis.Kletnieks
2006-07-25 4:49 ` Joshua Hudson
2006-07-25 12:43 ` Valdis.Kletnieks
2006-07-25 14:47 ` Horst H. von Brand
2006-07-23 2:19 ` Horst H. von Brand
2006-07-23 22:27 ` Vernon Mauery
2006-07-25 23:43 ` Peter Chubb
[not found] <6CcT1-1lH-39@gated-at.bofh.it>
[not found] ` <6Cwov-5xl-5@gated-at.bofh.it>
2006-07-25 21:28 ` Bodo Eggert
2006-07-26 1:00 ` Horst H. von Brand
2006-07-26 9:13 ` Bodo Eggert
2006-07-21 1:04 Joshua Hudson
2006-07-21 18:49 ` Horst H. von Brand
2006-07-21 20:28 ` Rob Sims
2006-07-21 21:57 ` Joshua Hudson
2006-07-24 6:42 ` Nikita Danilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607241755.k6OHtJuo006253@laptop13.inf.utfsm.cl \
--to=vonbrand@inf.utfsm.cl \
--cc=joshudson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).