From: Alexey Dobriyan <adobriyan@gmail.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 2/2] headers_check: fix #include regexp
Date: Sat, 29 Jul 2006 12:42:48 +0400 [thread overview]
Message-ID: <20060729084248.GE6843@martell.zuzino.mipt.ru> (raw)
In-Reply-To: <20060729082511.GB26956@flint.arm.linux.org.uk>
On Sat, Jul 29, 2006 at 09:25:11AM +0100, Russell King wrote:
> On Sat, Jul 29, 2006 at 12:22:49PM +0400, Alexey Dobriyan wrote:
> > Note it's [SPACE TAB]*
>
> Why not use [[:space:]] rather than [ ] ? It's hard to see what black
> characters on a black background are actually trying to do.
Indeed. What about this? I assume nobody sane would use \n, \f or \v in
between ;-)
[PATCH] headers_check: fix #include regexp
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
scripts/hdrcheck.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/scripts/hdrcheck.sh
+++ b/scripts/hdrcheck.sh
@@ -1,6 +1,6 @@
#!/bin/sh
-for FILE in `grep '^#include <' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
+for FILE in `grep '^[ \t]*#[ \t]*include[ \t]*<' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
if [ ! -r $1/$FILE ]; then
echo $2 requires $FILE, which does not exist in exported headers
exit 1
next prev parent reply other threads:[~2006-07-29 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 8:22 [PATCH 2/2] headers_check: fix #include regexp Alexey Dobriyan
2006-07-29 8:25 ` Russell King
2006-07-29 8:42 ` Alexey Dobriyan [this message]
[not found] ` <20060730122441.6db7bda2.akpm@osdl.org>
2006-08-01 4:24 ` [PATCH 2/2] headers_check: improve " Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060729084248.GE6843@martell.zuzino.mipt.ru \
--to=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).