From: Matthias Urlichs <smurf@smurf.noris.de>
To: Andrew Morton <akpm@osdl.org>
Cc: john stultz <johnstul@us.ibm.com>,
ak@muc.de, linux-kernel@vger.kernel.org, torvalds@osdl.org,
bunk@stusta.de, lethal@linux-sh.org, hirofumi@mail.parknet.co.jp,
asit.k.mallick@intel.com
Subject: Re: REGRESSION: the new i386 timer code fails to sync CPUs
Date: Mon, 31 Jul 2006 16:24:28 +0200 [thread overview]
Message-ID: <20060731142428.GF3662@kiste.smurf.noris.de> (raw)
In-Reply-To: <20060730020346.5d301bb5.akpm@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]
Hi,
Andrew Morton:
> > Hack out the i386 TSC sync code.
> >
> > diff --git a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c
> > index 6f5fea0..cd28914 100644
> > --- a/arch/i386/kernel/smpboot.c
> > +++ b/arch/i386/kernel/smpboot.c
> > @@ -435,7 +435,7 @@ static void __devinit smp_callin(void)
> > /*
> > * Synchronize the TSC with the BP
> > */
> > - if (cpu_has_tsc && cpu_khz && !tsc_sync_disabled)
> > + if (0 && cpu_has_tsc && cpu_khz && !tsc_sync_disabled)
> > synchronize_tsc_ap();
> > }
> >
> > @@ -1305,7 +1305,7 @@ static void __init smp_boot_cpus(unsigne
> > /*
> > * Synchronize the TSC with the AP
> > */
> > - if (cpu_has_tsc && cpucount && cpu_khz)
> > + if (0 && cpu_has_tsc && cpucount && cpu_khz)
> > synchronize_tsc_bp();
> > }
>
> I guess Matthias didn't test this patch. Can we get some obviously-correct
> fix in place for 2.6.18?
>
This patch doesn't change the problem.
--
Matthias Urlichs | {M:U} IT Design @ m-u-it.de | smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
- -
Success is always being able to wear clothing that you actually like.
-- SJM
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2006-07-31 14:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-22 23:36 REGRESSION: the new i386 timer code fails to sync CPUs Matthias Urlichs
2006-07-23 0:36 ` Andrew Morton
2006-07-23 8:16 ` Matthias Urlichs
2006-07-23 11:46 ` Andrew Morton
2006-07-23 12:08 ` Matthias Urlichs
2006-07-23 12:37 ` Andrew Morton
2006-07-23 12:58 ` Matthias Urlichs
2006-07-24 15:52 ` Siddha, Suresh B
2006-07-24 15:58 ` john stultz
2006-07-24 17:17 ` Matthias Urlichs
2006-07-24 17:51 ` Andi Kleen
2006-07-24 20:54 ` john stultz
2006-07-30 9:03 ` Andrew Morton
2006-07-30 9:49 ` Matthias Urlichs
2006-07-30 20:10 ` Andi Kleen
2006-07-30 20:55 ` Andrew Morton
2006-07-30 21:13 ` Matthias Urlichs
2006-07-30 21:20 ` Arjan van de Ven
2006-07-30 21:55 ` Matthias Urlichs
2006-08-01 1:47 ` Siddha, Suresh B
2006-08-01 3:14 ` Matthias Urlichs
2006-07-30 21:57 ` Andi Kleen
2006-07-30 22:28 ` Matthias Urlichs
2006-07-31 14:24 ` Matthias Urlichs [this message]
2006-07-24 17:39 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731142428.GF3662@kiste.smurf.noris.de \
--to=smurf@smurf.noris.de \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=asit.k.mallick@intel.com \
--cc=bunk@stusta.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=johnstul@us.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).