From: linas@austin.ibm.com (Linas Vepstas)
To: Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, Auke Kok <sofar@foo-projects.org>
Cc: linux-kernel@vger.kernel.org, john.ronciak@intel.com,
jesse.brandeburg@intel.com, jeffrey.t.kirsher@intel.com, "Zhang,
Yanmin" <yanmin.zhang@intel.com>
Subject: [PATCH]: e1000: Janitor: Use #defined values for literals
Date: Mon, 7 Aug 2006 15:16:58 -0500 [thread overview]
Message-ID: <20060807201658.GP10638@austin.ibm.com> (raw)
Resending patch from 23 June 2006; there was some confusion about
whether a similar patch had already been applied; seems it wasn't.
Minor janitorial patch: use #defines for literal values.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
----
drivers/net/e1000/e1000_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.18-rc3-mm2/drivers/net/e1000/e1000_main.c
===================================================================
--- linux-2.6.18-rc3-mm2.orig/drivers/net/e1000/e1000_main.c 2006-08-07 14:39:37.000000000 -0500
+++ linux-2.6.18-rc3-mm2/drivers/net/e1000/e1000_main.c 2006-08-07 15:06:31.000000000 -0500
@@ -4955,8 +4955,8 @@ static pci_ers_result_t e1000_io_slot_re
}
pci_set_master(pdev);
- pci_enable_wake(pdev, 3, 0);
- pci_enable_wake(pdev, 4, 0); /* 4 == D3 cold */
+ pci_enable_wake(pdev, PCI_D3hot, 0);
+ pci_enable_wake(pdev, PCI_D3cold, 0);
/* Perform card reset only on one instance of the card */
if (PCI_FUNC (pdev->devfn) != 0)
next reply other threads:[~2006-08-07 20:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 20:16 Linas Vepstas [this message]
2006-08-07 20:21 ` [PATCH]: e1000: Janitor: Use #defined values for literals Auke Kok
2006-08-07 20:29 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-06-23 16:36 Linas Vepstas
2006-06-23 18:07 ` Auke Kok
2006-06-23 20:07 ` Auke Kok
2006-06-23 21:12 ` Linas Vepstas
2006-06-27 17:32 ` Linas Vepstas
2006-06-27 18:03 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060807201658.GP10638@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sofar@foo-projects.org \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).