linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: michaelc@cs.wisc.edu
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: support larger block pc requests take 2
Date: Thu, 21 Sep 2006 20:59:39 +0200	[thread overview]
Message-ID: <20060921185939.GH16556@kernel.dk> (raw)
In-Reply-To: <20060921184024.GB16556@kernel.dk>

On Thu, Sep 21 2006, Jens Axboe wrote:
> On Fri, Sep 15 2006, michaelc@cs.wisc.edu wrote:
> > From: Mike Christie <michaelc@cs.wisc.edu>
> > 
> > This patch modifies blk_rq_map/unmap_user() so that it supports
> > requests larger than bio by chaning them together.
> > 
> > Changes since v1.
> > 1. Removed blk_get_bounced_bio() function. blk_rq_unmap_user
> > checks the bounced flag and if set access bi_private.
> > 
> > 2. Removed biohead_orig field from request.
> > Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> 
> Patches 1+2 applied, thanks Mike!

Tested, and no good. You can't split it into two patches, if it doesn't
compile with 1/2 applied. If scsi_ioctl.c needs to be changed, do it
with the change and not in the next patch. Otherwise bisecting breaks.

Care to resubmit? Just combine the two, but split the bsg patch as that
needs to go into a separate branch for now. The bsg patch will just be
merged into the bsg patch set, as that needs to be based on 'block'
anyway.

-- 
Jens Axboe


  reply	other threads:[~2006-09-21 18:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-16  3:08 [PATCH 1/2] block: support larger block pc requests take 2 michaelc
2006-09-16  3:08 ` [PATCH 2/2] block: convert blk_rq_map_users " michaelc
2006-09-21 18:40 ` [PATCH 1/2] block: support larger block pc requests " Jens Axboe
2006-09-21 18:59   ` Jens Axboe [this message]
2006-09-21 19:13     ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060921185939.GH16556@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).