From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751463AbWIUSzH (ORCPT ); Thu, 21 Sep 2006 14:55:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751461AbWIUSzG (ORCPT ); Thu, 21 Sep 2006 14:55:06 -0400 Received: from brick.kernel.dk ([62.242.22.158]:26167 "EHLO kernel.dk") by vger.kernel.org with ESMTP id S1751460AbWIUSzF (ORCPT ); Thu, 21 Sep 2006 14:55:05 -0400 Date: Thu, 21 Sep 2006 20:59:39 +0200 From: Jens Axboe To: michaelc@cs.wisc.edu Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] block: support larger block pc requests take 2 Message-ID: <20060921185939.GH16556@kernel.dk> References: <11583761161108-git-send-email-michaelc@cs.wisc.edu> <20060921184024.GB16556@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060921184024.GB16556@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 21 2006, Jens Axboe wrote: > On Fri, Sep 15 2006, michaelc@cs.wisc.edu wrote: > > From: Mike Christie > > > > This patch modifies blk_rq_map/unmap_user() so that it supports > > requests larger than bio by chaning them together. > > > > Changes since v1. > > 1. Removed blk_get_bounced_bio() function. blk_rq_unmap_user > > checks the bounced flag and if set access bi_private. > > > > 2. Removed biohead_orig field from request. > > Signed-off-by: Mike Christie > > Patches 1+2 applied, thanks Mike! Tested, and no good. You can't split it into two patches, if it doesn't compile with 1/2 applied. If scsi_ioctl.c needs to be changed, do it with the change and not in the next patch. Otherwise bisecting breaks. Care to resubmit? Just combine the two, but split the bsg patch as that needs to go into a separate branch for now. The bsg patch will just be merged into the bsg patch set, as that needs to be based on 'block' anyway. -- Jens Axboe