From: Pavel Machek <pavel@ucw.cz>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
mchehab@infradead.org, v4l-dvb-maintainer@linuxtv.org
Subject: Re: [PATCH] cx88xx: Fix lockup on suspend
Date: Fri, 5 Jan 2007 17:32:05 +0000 [thread overview]
Message-ID: <20070105173204.GB4745@ucw.cz> (raw)
In-Reply-To: <459DB421.4040408@shaw.ca>
Hi!
> Suspending with the cx88xx module loaded causes the
> system to lock up because the cx88_audio_thread kthread
> was missing a try_to_freeze() call, which caused it to
> go into a tight loop and result in softlockup when
> suspending. Fix that.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
>
Ack,
> ---
> linux-2.6.20-rc3-git4-orig/drivers/media/video/cx88/cx88-tvaudio.c 2007-01-04 19:51:45.000000000 -0600
> +++
> linux-2.6.20-rc3-git4/drivers/media/video/cx88/cx88-tvaudio.c 2007-01-04 19:25:19.000000000 -0600
> @@ -38,6 +38,7 @@
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> #include <linux/errno.h>
> +#include <linux/freezer.h>
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/mm.h>
but your patch was whitespace-damaged. Can you retry?
> @@ -961,6 +962,7 @@ int cx88_audio_thread(void *data)
> msleep_interruptible(1000);
> if (kthread_should_stop())
> break;
> + try_to_freeze();
>
Pavel
--
Thanks for all the (sleeping) penguins.
next prev parent reply other threads:[~2007-01-06 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 2:12 [PATCH] cx88xx: Fix lockup on suspend Robert Hancock
2007-01-05 17:32 ` Pavel Machek [this message]
[not found] <fa.zlXsUuWZNMJXOVESY6BoJRtki8Y@ifi.uio.no>
[not found] ` <fa.mPiA9bh9SZGXd2TrS/eQjWPc9oA@ifi.uio.no>
2007-01-06 18:25 ` Robert Hancock
2007-01-06 20:52 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070105173204.GB4745@ucw.cz \
--to=pavel@ucw.cz \
--cc=hancockr@shaw.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).