From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932138AbXAFUF7 (ORCPT ); Sat, 6 Jan 2007 15:05:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932139AbXAFUF7 (ORCPT ); Sat, 6 Jan 2007 15:05:59 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:49458 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932138AbXAFUF6 (ORCPT ); Sat, 6 Jan 2007 15:05:58 -0500 Date: Sat, 6 Jan 2007 12:04:36 -0800 From: Randy Dunlap To: Torsten Kaiser Cc: Olaf Hering , lkml , akpm Subject: Re: [PATCH] sysrq: showBlockedTasks is sysrq-W Message-Id: <20070106120436.6f0a3aa3.randy.dunlap@oracle.com> In-Reply-To: <200701062019.29974.tk13@bardioc.dyndns.org> References: <20070105110628.5f1e487d.rdunlap@xenotime.net> <20070105193605.GA14592@aepfle.de> <20070106102531.29ce662c.randy.dunlap@oracle.com> <200701062019.29974.tk13@bardioc.dyndns.org> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.3.0 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Jan 2007 20:19:29 +0100 Torsten Kaiser wrote: > On Saturday 06 January 2007 19:25, Randy Dunlap wrote: > > On Fri, 5 Jan 2007 20:36:05 +0100 Olaf Hering wrote: > > > > > > Weird, who failed to run this command before adding new stuff?! > > > find * -type f -print0 | xargs -0 env -i grep -nw register_sysrq_key > > > > > > sysrq x is for xmon, see arch/powerpc/xmon/xmon.c > > > Better switch the new stuff to 'z' or 'w' > > Also used: > * c for kexec/crashdump and emac (drivers/net/ibm_emac/ibm_emac_debug.c) ibm_emac is ppc 4xx only. Does kexec/crashdump work on that platform or are they mutually exclusive? > * g for KGDB on ppc Is that in mainline? > > From: Randy Dunlap > > > > SysRq showBlockedTasks is not done via B or T, it's done via W, > > so put that in the Help message. > > > > It was previously done via X, but X is already used for Xmon > > on powerpc platforms and this collision needs to be avoided. > > > @@ -342,8 +342,8 @@ static struct sysrq_key_op *sysrq_key_ta > > &sysrq_mountro_op, /* u */ > > /* May be assigned at init time by SMP VOYAGER */ > > NULL, /* v */ > > Nice marker that v is in use. > > > - NULL, /* w */ > > - &sysrq_showstate_blocked_op, /* x */ > > + &sysrq_showstate_blocked_op, /* w */ > > + NULL, /* x */ > > Wouldn't it be better to also put an marker for xmon here? > And marker for 'c' and 'g' (maybe even 'h')? OK, I'll do that. > > NULL, /* y */ > > NULL /* z */ > > }; > > Also Documentation/sysrq.txt is not uptodate. > > It is missing c (emac meaning), d (lockdep), n (un-RT), q (timer), w > (blocked) and x (xmon), but is documenting 'l' with no longer seems to be > implemented. and I'll look into that. Thanks. --- ~Randy