From: Mattia Dongili <malattia@linux.it>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@osdl.org>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.20-rc3-mm1 - rewrite-lock-in-cpufreq-to-eliminate-cpufreq-hotplug-related-issues.patch
Date: Sat, 6 Jan 2007 17:59:06 +0100 [thread overview]
Message-ID: <20070106165906.GK13533@inferi.kami.home> (raw)
In-Reply-To: <200701061344.l06DipYC003610@turing-police.cc.vt.edu>
On Sat, Jan 06, 2007 at 08:44:51AM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Thu, 04 Jan 2007 22:02:00 PST, Andrew Morton said:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc3/2.6.20-rc3-mm1/
>
> One of these 3 patches:
>
> rewrite-lock-in-cpufreq-to-eliminate-cpufreq-hotplug-related-issues.patch
> rewrite-lock-in-cpufreq-to-eliminate-cpufreq-hotplug-related-issues-fix.patch
> ondemand-governor-restructure-the-work-callback.patch
>
> causes an oops in kref_put during early boot ("unable to handle paging
> request at 00078").
>
> Dell Latitude D820 laptop, Core2 T7200 with a 64-bit kernel.
>
> Hand-copied trace of the oops:
>
> kobject_put+0x19/0x1b
> cpufreq_cpu_put+0xd/0x1e
> cpufreq_get+0x45/0x51
> handle_cpufreq_delayed_get+0x1e/0x41
> run_workqueue+0x9c/0x14e
> worker_thread+0x0/0x145
> worker_thread+0x10e/0x145
> default_wake_function+0x0/0xf
> worker_thread+0x0/0x145
> kthread+0x8/0x10b
> schedule_tail+0x38/0xa1
> child_rip+0xa/0x12
> kthread+0x0/0x10b
> child_rip+0x0/0x12
Does the following help?
Signed-off-by: Mattia Dongili <malattia@linux.it>
---
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index a7b17ab..1112f31 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1113,14 +1113,15 @@ unsigned int cpufreq_get(unsigned int cpu)
goto out;
if (unlikely(lock_policy_rwsem_read(cpu)))
- goto out;
+ goto out_policy;
ret_freq = __cpufreq_get(cpu);
unlock_policy_rwsem_read(cpu);
-out:
+out_policy:
cpufreq_cpu_put(policy);
+out:
return (ret_freq);
}
EXPORT_SYMBOL(cpufreq_get);
--
mattia
:wq!
next prev parent reply other threads:[~2007-01-06 16:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 6:02 2.6.20-rc3-mm1 Andrew Morton
2007-01-05 9:44 ` [-mm patch] lockdep: unbalance at generic_sync_sb_inodes Frederik Deweerdt
2007-01-05 12:16 ` [-mm patch] lockdep: possible deadlock in sysfs Frederik Deweerdt
2007-01-05 12:48 ` Oliver Neukum
2007-01-05 15:13 ` Oliver Neukum
2007-01-05 16:42 ` Frederik Deweerdt
2007-01-05 16:53 ` Oliver Neukum
2007-01-05 16:23 ` 2.6.20-rc3-mm1 Mariusz Kozlowski
2007-01-05 18:45 ` 2.6.20-rc3-mm1 Tim Schmielau
2007-01-08 12:36 ` 2.6.20-rc3-mm1 Mariusz Kozlowski
2007-01-05 20:55 ` 2.6.20-rc3-mm1 Benjamin Herrenschmidt
2007-01-05 21:15 ` 2.6.20-rc3-mm1 Andrew Morton
2007-01-05 21:24 ` 2.6.20-rc3-mm1 Benjamin Herrenschmidt
2007-01-08 19:32 ` 2.6.20-rc3-mm1 Cornelia Huck
2007-01-08 21:19 ` 2.6.20-rc3-mm1 Benjamin Herrenschmidt
2007-01-06 1:07 ` [-mm patch] make proc_dointvec_taint() static Adrian Bunk
2007-01-06 10:58 ` 2.6.20-rc3-mm1: umount reiser4 FS stuck in D state Laurent Riffard
2007-01-06 14:12 ` Laurent Riffard
2007-01-06 16:37 ` Jens Axboe
2007-01-06 18:58 ` Vladimir V. Saveliev
2007-01-12 22:56 ` Laurent Riffard
2007-01-23 16:40 ` Vladimir V. Saveliev
2007-01-23 15:46 ` Jens Axboe
2007-01-23 18:21 ` Laurent Riffard
2007-02-01 20:04 ` Edward Shishkin
2007-02-01 20:42 ` Laurent Riffard
2007-02-01 21:52 ` Edward Shishkin
2007-02-02 21:13 ` Laurent Riffard
2007-01-06 12:55 ` 2.6.20-rc3-mm1 - git-block.patch causes hard lockups Valdis.Kletnieks
2007-01-08 8:55 ` Jens Axboe
2007-01-09 18:03 ` Valdis.Kletnieks
2007-01-06 13:44 ` 2.6.20-rc3-mm1 - rewrite-lock-in-cpufreq-to-eliminate-cpufreq-hotplug-related-issues.patch Valdis.Kletnieks
2007-01-06 16:59 ` Mattia Dongili [this message]
2007-01-07 0:29 ` Valdis.Kletnieks
2007-01-06 15:20 ` 2.6.20-rc3-mm1 - reiser4-sb_sync_inodes.patch causes boot hang Valdis.Kletnieks
2007-01-06 19:14 ` Andrew Morton
2007-01-07 0:28 ` Valdis.Kletnieks
2007-01-09 14:40 ` [Re: 2.6.20-rc3-mm1] BUG: at kernel/sched.c:3415 sub_preempt_count() Maciej Rutecki
2007-01-09 15:28 ` Frederik Deweerdt
2007-01-09 20:50 ` Maciej Rutecki
2007-01-09 21:06 ` Frederik Deweerdt
2007-01-10 16:54 ` Maciej Rutecki
2007-01-11 18:28 ` [-mm patch] remove tcp header from tcp_v4_check Frederik Deweerdt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070106165906.GK13533@inferi.kami.home \
--to=malattia@linux.it \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).