From: Mikael Pettersson <mikpe@it.uu.se>
To: jeff@garzik.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support
Date: Mon, 8 Jan 2007 09:08:53 +0100 (MET) [thread overview]
Message-ID: <200701080808.l0888rBb001303@harpo.it.uu.se> (raw)
On Sun, 07 Jan 2007 20:47:35 -0500, Jeff Garzik wrote:
> Mikael Pettersson wrote:
> > @@ -789,8 +789,14 @@ static void pdc_exec_command_mmio(struct
> > static int pdc_check_atapi_dma(struct ata_queued_cmd *qc)
> > {
> > u8 *scsicmd = qc->scsicmd->cmnd;
> > + struct ata_port *ap = qc->ap;
> > + struct pdc_host_priv *hp = ap->host->private_data;
> > int pio = 1; /* atapi dma off by default */
> >
> > + /* First generation chips cannot use ATAPI DMA on SATA ports */
> > + if (!(hp->flags & PDC_FLAG_GEN_II) && sata_scr_valid(ap))
> > + return 1;
> > +
> > /* Whitelist commands that may use DMA. */
> > switch (scsicmd[0]) {
> > case WRITE_12:
>
>
> IMO creating a new check_atapi_dma function for first-gen chips would be
> the preferred way to add this check.
Agreed. Will do.
/Mikael
next reply other threads:[~2007-01-08 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 8:08 Mikael Pettersson [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-01-07 22:39 [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support Mikael Pettersson
2007-01-08 1:47 ` Jeff Garzik
2007-01-08 10:30 ` Alan
2007-01-06 20:32 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701080808.l0888rBb001303@harpo.it.uu.se \
--to=mikpe@it.uu.se \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).