linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: vgoyal@in.ibm.com, vatsa@in.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Change cpu_up and co from __devinit to __cpuinit
Date: Mon, 8 Jan 2007 14:45:33 -0800	[thread overview]
Message-ID: <20070108144533.186a40c6.akpm@osdl.org> (raw)
In-Reply-To: <20070106093907.pu7mzlzeo0c4ck8s@imap.linux.ibm.com>

On Sat,  6 Jan 2007 09:39:07 -0500
Gautham R Shenoy <ego@in.ibm.com> wrote:

> Compiling the kernel with CONFIG_HOTPLUG = y and CONFIG_HOTPLUG_CPU = n
> with CONFIG_RELOCATABLE = y generates the following modpost warnings
> 
> WARNING: vmlinux - Section mismatch: reference to .init.data: from
> .text between '_cpu_up' (at offset 0xc0141b7d) and 'cpu_up'
> WARNING: vmlinux - Section mismatch: reference to .init.data: from
> .text between '_cpu_up' (at offset 0xc0141b9c) and 'cpu_up'
> WARNING: vmlinux - Section mismatch: reference to .init.text:__cpu_up
> from .text between '_cpu_up' (at offset 0xc0141bd8) and 'cpu_up'
> WARNING: vmlinux - Section mismatch: reference to .init.data: from
> .text between '_cpu_up' (at offset 0xc0141c05) and 'cpu_up'
> WARNING: vmlinux - Section mismatch: reference to .init.data: from
> .text between '_cpu_up' (at offset 0xc0141c26) and 'cpu_up'
> WARNING: vmlinux - Section mismatch: reference to .init.data: from
> .text between '_cpu_up' (at offset 0xc0141c37) and 'cpu_up'

I suppose we should treat this as a 2.6.20 bugfix.

> --- linux-2.6.20-rc3.orig/kernel/cpu.c
> +++ linux-2.6.20-rc3/kernel/cpu.c
> @@ -210,7 +210,7 @@ int cpu_down(unsigned int cpu)
>    #endif /*CONFIG_HOTPLUG_CPU*/
> 
>    /* Requires cpu_add_remove_lock to be held */
> -static int __devinit _cpu_up(unsigned int cpu)
> +static int __cpuinit _cpu_up(unsigned int cpu)
>    {

Well that's new.  space-stuffed emails are common enough, but you've worked
out how to do space-double-stuffing.


      reply	other threads:[~2007-01-08 22:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-06 14:39 [PATCH] Change cpu_up and co from __devinit to __cpuinit Gautham R Shenoy
2007-01-08 22:45 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070108144533.186a40c6.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vatsa@in.ibm.com \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).