From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751240AbXAIJtT (ORCPT ); Tue, 9 Jan 2007 04:49:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751239AbXAIJtT (ORCPT ); Tue, 9 Jan 2007 04:49:19 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:41279 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbXAIJtS (ORCPT ); Tue, 9 Jan 2007 04:49:18 -0500 Date: Tue, 9 Jan 2007 10:44:45 +0100 From: Ingo Molnar To: Srivatsa Vaddagiri Cc: Andrew Morton , Oleg Nesterov , David Howells , Christoph Hellwig , Linus Torvalds , linux-kernel@vger.kernel.org, Gautham shenoy Subject: Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist Message-ID: <20070109094445.GA12773@elte.hu> References: <20070106163035.GA2948@tv-sign.ru> <20070106163851.GA13579@in.ibm.com> <20070106111117.54bb2307.akpm@osdl.org> <20070107110013.GD13579@in.ibm.com> <20070107115957.6080aa08.akpm@osdl.org> <20070107210139.GA2332@tv-sign.ru> <20070108155428.d76f3b73.akpm@osdl.org> <20070109050417.GC589@in.ibm.com> <20070108212656.ca77a3ba.akpm@osdl.org> <20070109093302.GE589@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070109093302.GE589@in.ibm.com> User-Agent: Mutt/1.4.2.2i X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.6 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.6 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.0.3 -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Srivatsa Vaddagiri wrote: > This thread makes absolutely -no- calls to try_to_freeze() in its > lifetime. that's a plain bug. suspend will fail for example. A kernel thread either needs to mark itself PF_NOFREEZE (which means it can be ignored and zapped with impunity), or needs to call into try_to_freeze() with a sane frequency. Ingo