From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Tony Jones <tonyj@suse.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chrisw@sous-sol.org, linux-security-module@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks
Date: Wed, 7 Feb 2007 12:11:25 +0000 [thread overview]
Message-ID: <20070207121125.GA15989@infradead.org> (raw)
In-Reply-To: <200702070158.15997.agruen@suse.de>
On Wed, Feb 07, 2007 at 01:58:15AM -0800, Andreas Gruenbacher wrote:
> > It's not actually a pathname we care about, but a vfsmount + dentry
> > combo. That one means as much in nfsd as elsewhere. We want nfsd
> > to obey r/o or noatime mount flags if /export/foo is exported with them
> > but /foo not.
>
> This assumes that you can discover from the file handle which export it
> belongs to. And right, this can be done using the fsid export option. Okay,
> I'm now convinced that passing the vfsmounts from the svc_export to the vfs_
> helpers is good at least for *something*. I'll update the patches.
As I mentioned before I have a big patchset reworking this area, so please
wait a week or two for me two finish it instead of creating lots of rejects.
> > This doesn't matter. hardlinks are per definition on the same vfsmount.
>
> Hardlinks are per definition on the same filesystem. This doesn't mean that
> you can't have two filehandles for the same file but with different
> vfsmounts -- you can have the same file visible in multiple locations, each
> with their own vfsmount.
Sure, but that doesn't matter here. Exports are per-vfsmount, and
each export has the vfsmount stored in it. So we know which of the
vfsmount we want before we even resolve the dentry. And yes, if
I have /export/foo mounted with option but /foo now I want those
options to apply to the nfs export. Note that we actually have another
little bug in this area currently: if you export two different
patch that have the same underlying filesystems they actually do get
the same file handle unless using fsid=. We probably need to put
a check into svc_export_parse so that we don't export the same
device twice without using fsid=.
next prev parent reply other threads:[~2007-02-07 12:11 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 18:22 [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks Tony Jones
2007-02-05 18:22 ` [RFC 1/28] Pass struct vfsmount to the inode_create LSM hook Tony Jones
2007-02-05 18:22 ` [RFC 2/28] Remove redundant check from proc_setattr() Tony Jones
2007-02-05 19:16 ` Chris Wright
2007-02-05 18:22 ` [RFC 3/28] Pass struct file down to remove_suid and children Tony Jones
2007-02-05 18:22 ` [RFC 4/28] Add a vfsmount parameter to notify_change() Tony Jones
2007-02-05 18:23 ` [RFC 5/28] Pass struct vfsmount to the inode_setattr LSM hook Tony Jones
2007-02-05 18:23 ` [RFC 6/28] Add struct vfsmount parameter to vfs_mkdir() Tony Jones
2007-02-05 18:23 ` [RFC 7/28] Pass struct vfsmount to the inode_mkdir LSM hook Tony Jones
2007-02-05 18:23 ` [RFC 8/28] Add a struct vfsmount parameter to vfs_mknod() Tony Jones
2007-02-05 18:23 ` [RFC 9/28] Pass struct vfsmount to the inode_mknod LSM hook Tony Jones
2007-02-05 18:23 ` [RFC 10/28] Add a struct vfsmount parameter to vfs_symlink() Tony Jones
2007-02-05 18:23 ` [RFC 11/28] Pass struct vfsmount to the inode_symlink LSM hook Tony Jones
2007-02-05 18:24 ` [RFC 12/28] Pass struct vfsmount to the inode_readlink " Tony Jones
2007-02-05 18:24 ` [RFC 13/28] Add struct vfsmount parameters to vfs_link() Tony Jones
2007-02-05 18:24 ` [RFC 14/28] Pass struct vfsmount to the inode_link LSM hook Tony Jones
2007-02-05 18:24 ` [RFC 15/28] Add a struct vfsmount parameter to vfs_rmdir() Tony Jones
2007-02-05 18:24 ` [RFC 16/28] Pass struct vfsmount to the inode_rmdir LSM hook Tony Jones
2007-02-05 18:24 ` [RFC 17/28] Add a struct vfsmount parameter to vfs_unlink() Tony Jones
2007-02-05 18:25 ` [RFC 18/28] Pass struct vfsmount to the inode_unlink LSM hook Tony Jones
2007-02-05 18:25 ` [RFC 19/28] Add struct vfsmount parameters to vfs_rename() Tony Jones
2007-02-05 18:25 ` [RFC 20/28] Pass struct vfsmount to the inode_rename LSM hook Tony Jones
2007-02-05 18:25 ` [RFC 21/28] Add a struct vfsmount parameter to vfs_setxattr() Tony Jones
2007-02-05 18:25 ` [RFC 22/28] Pass struct vfsmount to the inode_setxattr LSM hook Tony Jones
2007-02-05 18:25 ` [RFC 23/28] Add a struct vfsmount parameter to vfs_getxattr() Tony Jones
2007-02-05 18:25 ` [RFC 24/28] Pass struct vfsmount to the inode_getxattr LSM hook Tony Jones
2007-02-05 18:26 ` [RFC 25/28] Add a struct vfsmount parameter to vfs_listxattr() Tony Jones
2007-02-05 18:26 ` [RFC 26/28] Pass struct vfsmount to the inode_listxattr LSM hook Tony Jones
2007-02-05 18:26 ` [RFC 27/28] Add a struct vfsmount parameter to vfs_removexattr() Tony Jones
2007-02-05 18:26 ` [RFC 28/28] Pass struct vfsmount to the inode_removexattr LSM hook Tony Jones
2007-02-05 18:44 ` [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks Christoph Hellwig
2007-02-05 18:58 ` Trond Myklebust
2007-02-05 19:02 ` Christoph Hellwig
2007-02-06 3:20 ` Andreas Gruenbacher
2007-02-06 8:51 ` Trond Myklebust
2007-02-06 9:48 ` Christoph Hellwig
2007-02-06 10:31 ` Neil Brown
2007-02-07 9:25 ` Andreas Gruenbacher
2007-02-06 9:47 ` Christoph Hellwig
2007-02-06 10:26 ` Neil Brown
2007-02-06 10:37 ` Christoph Hellwig
2007-02-12 18:32 ` J. Bruce Fields
2007-02-07 9:58 ` Andreas Gruenbacher
2007-02-07 12:11 ` Christoph Hellwig [this message]
2007-02-05 19:15 ` Chris Wright
2007-02-06 0:44 ` Andreas Gruenbacher
2007-02-06 2:13 ` Andreas Gruenbacher
2007-02-06 9:52 ` Christoph Hellwig
2007-02-07 9:04 ` Andreas Gruenbacher
2007-02-06 12:55 ` Stephen Smalley
2007-02-07 8:55 ` Andreas Gruenbacher
2007-02-07 15:43 ` Chris Wright
2007-02-07 16:06 ` Stephen Smalley
2007-02-07 16:25 ` Jeff Mahoney
2007-02-07 19:55 ` Andreas Gruenbacher
2007-02-05 19:26 ` Casey Schaufler
2007-02-05 19:39 ` Arjan van de Ven
2007-02-05 19:50 ` Chris Wright
2007-02-05 20:23 ` Casey Schaufler
2007-02-06 2:30 ` Andreas Gruenbacher
2007-02-06 14:20 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070207121125.GA15989@infradead.org \
--to=hch@infradead.org \
--cc=agruen@suse.de \
--cc=chrisw@sous-sol.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tonyj@suse.de \
--cc=trond.myklebust@fys.uio.no \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).